Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shipping labels] Remove label paper size from shipment details to match updated designs #14055

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

rachelmcr
Copy link
Contributor

Part of: #14044

Description

This removes the label paper size dropdown menu from the shipment details bottom sheet, in the new Woo Shipping label creation flow, per the design discussion in pe5pgL-5rm-p2#comment-4584.

Testing information

  1. Install and set up the Woo Shipping extension on your store.
  2. Build and run the app with the revampedShippingLabelCreation feature flag enabled.
  3. Create an order with the processing status and at least one physical product.
  4. In the order details, select "Create Shipping Label."
  5. Confirm the bottom sheet appears and is collapsed with the "Shipment details" label.
  6. Tap or drag the bottom sheet to expand it, and confirm the expected bottom sheet UI is visible.
  7. Confirm the "Mark as complete" toggle and purchase button are at the bottom of the screen, and the label paper size menu is removed.

Screenshots

Before After
Simulator Screenshot - iPhone 16 Pro - 2024-09-26 at 17 36 27 Simulator Screenshot - iPhone 16 Pro - 2024-09-27 at 09 39 36

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@rachelmcr rachelmcr added the feature: shipping labels Related to creating, ordering, or printing shipping labels. label Sep 27, 2024
@rachelmcr rachelmcr added this to the 20.6 milestone Sep 27, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 20.6. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14055-6d387ec
Version20.5
Bundle IDcom.automattic.alpha.woocommerce
Commit6d387ec
App Center BuildWooCommerce - Prototype Builds #11034
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@rachelmcr rachelmcr merged commit 862aea9 into trunk Sep 27, 2024
19 checks passed
@rachelmcr rachelmcr deleted the issue/14044-shipment-details-papersize branch September 27, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: shipping labels Related to creating, ordering, or printing shipping labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants