Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Woo POS] Finalise design of payment success screen for pos demo build #14073

Merged
merged 7 commits into from
Oct 1, 2024

Conversation

joshheald
Copy link
Contributor

@joshheald joshheald commented Sep 30, 2024

Closes: #14063

Description

This PR updates the success screen in POS to match final designs:

  • Use less bright green
  • Restore the checkmark icon
  • Remove the icon from the New Order button
  • Fix the spacing and height of the New Order button

Additionally, I've updated the description for the menu item to the newly agreed string: Accept payments at your physical store

Designs

CleanShot 2024-09-30 at 14 12 24@2x

TfaZ4LUkEwEGrxfnEFzvJj-fi-2530_13218

Note that I have used posSecondaryBackground, not gutenbergGrey900, as we don't have the latter defined in the project and this screen should match the item list from the first screen.

Steps to reproduce

  1. Launch the app and navigate to POS
  2. Take a payment
  3. Observe that the success screen matches designs

Testing information

No unit tests: UI changes only. I've tested this on an iPad running iOS 17

Screenshots

dark success screen
light success screen
new description highlighted


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@joshheald joshheald added type: task An internally driven task. feature: POS labels Sep 30, 2024
@joshheald joshheald added this to the 20.7 milestone Sep 30, 2024
@joshheald
Copy link
Contributor Author

@joe-keenan tagging you here, but don't worry about it if you don't have time, Gabriel's review is enough.

@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14073-6becedf
Version20.6
Bundle IDcom.automattic.alpha.woocommerce
Commit6becedf
App Center BuildWooCommerce - Prototype Builds #11059
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@iamgabrielma iamgabrielma self-assigned this Oct 1, 2024
Copy link
Contributor

@iamgabrielma iamgabrielma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this. Changes look good in both light and dark mode 🚢

@iamgabrielma iamgabrielma merged commit 5b6a8bd into trunk Oct 1, 2024
14 checks passed
@iamgabrielma iamgabrielma deleted the task/finalise-colours-for-pos-demo branch October 1, 2024 01:48
@joe-keenan
Copy link

Yep, looks good to me, too! Thanks for the last minute update!

(I want to remove the shadow on the check mark graphic, but it’s not a dealbreaker)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: POS type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Woo POS] Update colors for the payment success screen
4 participants