-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Woo POS] Finalise design of payment success screen for pos demo build #14073
Conversation
This reverts commit d5fe8da.
@joe-keenan tagging you here, but don't worry about it if you don't have time, Gabriel's review is enough. |
📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this. Changes look good in both light and dark mode 🚢
Yep, looks good to me, too! Thanks for the last minute update! (I want to remove the shadow on the check mark graphic, but it’s not a dealbreaker) |
Closes: #14063
Description
This PR updates the success screen in POS to match final designs:
Additionally, I've updated the description for the menu item to the newly agreed string:
Accept payments at your physical store
Designs
TfaZ4LUkEwEGrxfnEFzvJj-fi-2530_13218
Note that I have used
posSecondaryBackground
, notgutenbergGrey900
, as we don't have the latter defined in the project and this screen should match the item list from the first screen.Steps to reproduce
Testing information
No unit tests: UI changes only. I've tested this on an iPad running iOS 17
Screenshots
RELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: