Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved out label "Suggested by AI" in BlazeCampaignCreationForm layout #14074

Merged

Conversation

pmusolino
Copy link
Member

@pmusolino pmusolino commented Sep 30, 2024

Related to #12671

Description

This PR reverts the recent changes made to the BlazeCampaignCreationForm layout, specifically moving the "Suggested by AI" label and the edit ad button back to their original positions. This decision follows a discussion highlighting concerns about the label's placement within the Ad Preview section C03L1NF1EA3/p1727177421848799

Steps to reproduce

  • Ensure that the visual layout in the form matches the original design specifications.

Testing information

Followed the same steps as Steps to reproduce.

Screenshots

Before After
Simulator Screenshot - iPhone 16 Pro - 2024-09-30 at 15 59 09 Simulator Screenshot - iPhone 16 Pro - 2024-09-30 at 16 06 53

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

…ted by AI' label and edit ad button into a VStack
@pmusolino pmusolino added type: enhancement A request for an enhancement. feature: Blaze Related to the integration of the Blaze ads platform labels Sep 30, 2024
@pmusolino pmusolino added this to the 20.7 milestone Sep 30, 2024
@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14074-72370a7
Version20.6
Bundle IDcom.automattic.alpha.woocommerce
Commit72370a7
App Center BuildWooCommerce - Prototype Builds #11060
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@itsmeichigo itsmeichigo self-assigned this Oct 1, 2024
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@pmusolino pmusolino merged commit 466e8ed into trunk Oct 1, 2024
21 of 23 checks passed
@pmusolino pmusolino deleted the issue/suggested-by-ai-in-blaze-moved-inside-the-right-view branch October 1, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: Blaze Related to the integration of the Blaze ads platform type: enhancement A request for an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants