Update ListSelectorViewController to use safe index accessors #14077
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #14070
peaMlT-Vj-p2
Context
command.data[indexPath.row]
should never fail as the dataset does not mutate, but according to crash reports it does.I assume that this happens when the view is used in a SwiftUI hosting environment and some variables could be updated or mutated due to the underlying view lifecycle, causing the command data to be inconsistent with the current index path.
How
ListSelectorViewController
to use safe index accessors to prevent any out of index crash.RELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: