Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Store: added missing divider line above "View All store analytics" button in Top performers card #14104

Conversation

pmusolino
Copy link
Member

Closes: #14042

Description

The top performers card was shown without a divider line above the "View all store analytics" button. In comparison, the "Performance" card above it does have the line, as do the other cards. Added the missing separator.

Steps to reproduce

The separator should appear on top of "View All store analytics" button in Top performers card.

Testing information

Tested that the separator now appear on top of "View All store analytics" button in Top performers card on iOS 18 simulator, Xcode 16.

Screenshots

Before After
2024-09-25 17 59 50 Simulator Screenshot - iPhone 16 Pro - 2024-10-04 at 17 36 36

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@pmusolino pmusolino added the type: enhancement A request for an enhancement. label Oct 4, 2024
@pmusolino pmusolino added this to the 20.7 milestone Oct 4, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Oct 4, 2024

1 Warning
⚠️ This PR is assigned to the milestone 20.8. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14104-bf1eb76
Version20.6
Bundle IDcom.automattic.alpha.woocommerce
Commitbf1eb76
App Center BuildWooCommerce - Prototype Builds #11108
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@hafizrahman hafizrahman self-assigned this Oct 8, 2024
Copy link
Contributor

@hafizrahman hafizrahman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in both iPad and iOS 17.5 in Simulator.

@wpmobilebot wpmobilebot modified the milestones: 20.7, 20.8 Oct 11, 2024
@wpmobilebot
Copy link
Collaborator

Version 20.7 has now entered code-freeze, so the milestone of this PR has been updated to 20.8.

@itsmeichigo itsmeichigo merged commit d55a92d into trunk Oct 14, 2024
19 of 21 checks passed
@itsmeichigo itsmeichigo deleted the issue/14042-My-Store-Top-performers-card-missing-divider-line-above-View-all-store-analytics branch October 14, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A request for an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

My Store: Top performers card missing divider line above "View all store analytics"
5 participants