-
Notifications
You must be signed in to change notification settings - Fork 119
[Custom Fields] Delete fields #14177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated by 🚫 Danger |
|
|
4d6e67a to
ef0e542
Compare
ef0e542 to
06a41c4
Compare
a513dab to
f5a75eb
Compare
WooCommerce/Classes/ViewRelated/Custom Fields/CustomFieldEditorView.swift
Outdated
Show resolved
Hide resolved
…list-details' into issue/14156-delete-custom-fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested with both new and existing fields and the deletion and undo work as expected ✅.
I left some non-blocking comments and suggestions below.
Closes: #14156
Description
This PR adds support for deleting custom fields, it has the following changes:
Steps to reproduce
Testing information
Screenshots
Simulator.Screen.Recording.-.iPhone.15.-.2024-10-21.at.17.32.21.mp4
RELEASE-NOTES.txtif necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: