[Tooling] Use bot for release management git operations #14207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iangmaia
added
the
category: tooling
|
|
iangmaia
force-pushed
the
iangmaia/use-trusted-mac-agents-for-releases
branch
6 times, most recently
from
104e10e to
e47032a
Compare
iangmaia
added
the
status: do not merge
iangmaia
force-pushed
the
iangmaia/use-trusted-mac-agents-for-releases
branch
from
92fe0db to
0986713
Compare
iangmaia
force-pushed
the
iangmaia/use-trusted-mac-agents-for-releases
branch
from
2ccb778 to
746167d
Compare
mokagio
approved these changes
Oct 31, 2024
Comment on lines
17
to
+21
| echo '--- :git: Checkout Release Branch' | ||
| .buildkite/commands/checkout-release-branch.sh "$RELEASE_VERSION" | ||
|
|
||
| echo '--- :ruby: Setup Ruby Tools' | ||
| install_gems |
There was a problem hiding this comment.
By the way, I think this is the best approach to run bundle install. That is, we should always run it after checking out the release branch. Otherwise, we might run into the edge case of having the branch that triggered the build using a gemset different from the release branch which could lead to gnarly issues.
There was a problem hiding this comment.
🎯
This is something I noticed in a lot of pipelines across our repos, that install_gems was running before checking out the new branch, so I've changed it with the use-bot-for-git change.
.buildkite/release-pipelines/update-metadata-on-app-store-connect.yml
Outdated
Show resolved
Hide resolved
iangmaia
removed
the
status: do not merge
staskus
force-pushed
the
task/enable-xcode-16
branch
from
fbcfd50 to
b702c12
Compare
|
@iangmaia Xcode 16.1 PR is merged. |
…ations with write access
…ping only version bump
…ane, keeping only version bump" This reverts commit e47032a.
This reverts commit 73a634a.
Co-authored-by: Gio Lodi <[email protected]>
iangmaia
force-pushed
the
iangmaia/use-trusted-mac-agents-for-releases
branch
from
78843d3 to
8731800
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Android counterpart: woocommerce/woocommerce-android#11886
Original task describing the problem: https://github.com/Automattic/apps-infra-plans/issues/39
See paaHJt-6EP-p2 for more details.
What it does
This PR updates the release pipelines to use the
use-bot-for-gitscript to use a bot account for git operations, avoiding the need for SSH deploy keys with write permission.How to test
We'll fully run the release pipelines in the next release cycle once this is merged.
To test it, I've commented out a few side effects from
start_code_freezeon e47032a and ran it directly on Buildkite (setting the env varPIPELINE=release-pipelines/start-code-freeze.yml) with this resulting build.Dependencies
This PR targets #14225 (fixing issues with Xcode 16).