Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Product Global Unique ID] Show backend ID in product details inventory #14228

Merged
merged 7 commits into from
Oct 29, 2024

Conversation

toupper
Copy link
Contributor

@toupper toupper commented Oct 28, 2024

Closes: #14193

Description

With this PR we show the global unique identifier retrieved in the network request in the product inventory settings.

Steps to reproduce

Set the global unique identifier on a product or variation in wp-admin. Then:

Product

  1. Go to products
  2. Tap on the product with the global unique identifier set
  3. Tap on Inventory
  4. The global unique identifier should be set (see video)

Variation

  1. Go to products
  2. Tap on the product with the global unique identifier set for a variation
  3. Tap on Variations
  4. Select the variation with the global unique identifier set
  5. Tap on Inventory
  6. The global unique identifier should be set (see video)

Testing information

Screenshots

Product

Simulator.Screen.Recording.-.iPhone.16.-.2024-10-25.at.17.17.36.mp4

Variation

Simulator.Screen.Recording.-.iPhone.16.-.2024-10-28.at.15.47.59.mp4

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@dangermattic
Copy link
Collaborator

dangermattic commented Oct 28, 2024

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@toupper toupper marked this pull request as draft October 28, 2024 13:38
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 28, 2024

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14228-c27bfe9
Version20.9
Bundle IDcom.automattic.alpha.woocommerce
Commitc27bfe9
App Center BuildWooCommerce - Prototype Builds #11316
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@toupper toupper added type: task An internally driven task. feature: add/edit products Related to adding or editing products. labels Oct 28, 2024
@toupper toupper added this to the 21.0 milestone Oct 28, 2024
@toupper toupper changed the title Issue/14193 gtin UI product details inventory [Product Global Unique ID] UI in product details inventory Oct 29, 2024
@toupper toupper marked this pull request as ready for review October 29, 2024 08:06
@toupper toupper merged commit 2f2ab6c into trunk Oct 29, 2024
14 checks passed
@toupper toupper deleted the issue/14193-gtin-ui-product-details-inventory branch October 29, 2024 08:06
@toupper toupper changed the title [Product Global Unique ID] UI in product details inventory [Product Global Unique ID] Show backend ID in product details inventory Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: add/edit products Related to adding or editing products. type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show value in Product Details (Inventory)
3 participants