[Core Data] Keep product image's dateCreated optional.

[selanthiraiyan]

Closes: #14312

Description

In #14013 we made the Product object’s date and dateCreated properties optional, to avoid crashes when transforming deleted product objects in Core Data. It’s possible that (now that we aren’t crashing on the product objects) a similar crash is now happening when transforming deleted product image objects.

This PR follows the same approach from #14013 and marks the dateCreated Swift property of ProductImage as optional.

Steps to reproduce

Read the following excerpt from internal discussion - p91TBi-cd4-p2

When attempting to apply the update to the background context using persistent container’s newBackgroundContext and automaticallyMergesChangesFromParent turned off for the view context, I encountered a crash in Product+ReadOnlyConvertible when converting a product’s date and dateCreated from a storage model to a readonly object.

These attributes were declared as non-optional without any default values. A Core Data object can be deleted and there can still be a reference to it somewhere, therefore things that are marked as non-optional can be gone at runtime since Core Data can never fulfill its dynamic expectation.

The solution is to always be mindful when using non-optionals with Core Data in case we want to manually handle the merging for the view context in the future. We can set default values for the above date attributes or make them optional and set default values to them when finding nil values while converting to readonly objects.

To ensure safety, we should check all the other existing entities for non-optional attributes without default values. We should also do a thorough smoke test to see if there’s any similar crash happening anywhere else in the app.

Based on the above explanation, this crash is related to introducing background context to core data. This cannot be reproduced locally following a fixed set of steps.

• Install a build from trunk
• Login into the app
• Switch to this branch and run the app to replace the build from trunk
• Create a product with images
• Smoke test that product image upload, viewing and deletion works as expected

Testing information

• I tested that a build from trunk can be replaced without any core data related crashes.
• I tested that product image upload, viewing and deletion works as expected.

Screenshots

---

• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

• The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
• Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
• Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

[dangermattic]

	1 Message
📖	This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS
	Build Number	pr14317-84e15e1
	Version	21.0
	Bundle ID	com.automattic.alpha.woocommerce
	Commit	84e15e1
	App Center Build	WooCommerce - Prototype Builds #11452

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[rachelmcr]

I can't reproduce the reported crash, either, but the testing steps here worked well for me. I also tested deleting a product with an image and had no issues with that, either.

I'll go ahead and merge this fix so we can release a new beta!

[sentry-io]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ EXC_BREAKPOINT: Exception 6, Code 1, Subcode 6571544800 ProductImage.toReadOnly View Issue
• ‼️ EXC_BREAKPOINT: Exception 6, Code 1, Subcode 6682751816 > ProductImage.toReadOnly View Issue
• ‼️ EXC_BREAKPOINT: Exception 6, Code 1, Subcode 7000527072 ProductImage.toReadOnly View Issue

_{Did you find this useful? React with a 👍 or 👎}