Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shipping labels] Add networking layer support for label status endpoint #14488

Merged
merged 5 commits into from
Nov 26, 2024

Conversation

rachelmcr
Copy link
Contributor

Part of: #14053

Description

This adds the Networking layer support for checking the status of a label after purchasing it. It can be used immediately after the purchase request to poll for the completed purchase.

How

  • The response can be decoded as the existing ShippingLabelStatusPollingResponse, so we keep using that model.
  • Introduces a new mapper because the new endpoint only returns a single label's status at a time.
  • Introduces the new endpoint in WooShippingRemote.
  • Adds a mock response and unit test support.

Testing information

This endpoint is not yet used in the app; confirm unit tests pass.


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@rachelmcr rachelmcr added the feature: shipping labels Related to creating, ordering, or printing shipping labels. label Nov 21, 2024
@rachelmcr rachelmcr added this to the 21.2 milestone Nov 21, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 21, 2024

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14488-9c0c256
Version21.1
Bundle IDcom.automattic.alpha.woocommerce
Commit9c0c256
App Center BuildWooCommerce - Prototype Builds #11760
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@rachelmcr rachelmcr modified the milestones: 21.2, 21.3 Nov 21, 2024
@rachelmcr
Copy link
Contributor Author

These changes are complete but I'm waiting for checks to pass. Feel free to merge this, or I will merge it when I'm back from AFK.

@rachelmcr rachelmcr merged commit 01ccadc into trunk Nov 26, 2024
14 checks passed
@rachelmcr rachelmcr deleted the issue/14053-label-status-networking branch November 26, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: shipping labels Related to creating, ordering, or printing shipping labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants