Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reveal animation from orders list #14633

Merged

Conversation

bozidarsevo
Copy link
Contributor

@bozidarsevo bozidarsevo commented Dec 9, 2024

Closes: #14025

Description

  • Removed reveal animation from orders list

Testing information

  • Open the app and navigate to the orders tab
  • Pull to refresh
  • See the first order row no more has the glitch due to the reveal animation (since it is now removed)

Screenshots

With reveal Without reveal
Simulator Screenshot - iPhone 16 Pro - 2024-12-09 at 12 41 55 Simulator Screenshot - iPhone 16 Pro - 2024-12-09 at 12 42 15

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@bozidarsevo bozidarsevo added type: bug A confirmed bug. feature: order list Related to the order list. labels Dec 9, 2024
@bozidarsevo bozidarsevo added this to the 21.3 milestone Dec 9, 2024
@bozidarsevo
Copy link
Contributor Author

I see that we use glanceTrailingActionsIfNeeded() also in ProductCategoryListViewController and ProductsViewController, should we remove it from there also?

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 9, 2024

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14633-aeae8bc
Version21.2
Bundle IDcom.automattic.alpha.woocommerce
Commitaeae8bc
App Center BuildWooCommerce - Prototype Builds #12059
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@bozidarsevo bozidarsevo marked this pull request as ready for review December 9, 2024 12:07
Copy link
Contributor

@toupper toupper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tests well! 🚢

@bozidarsevo bozidarsevo merged commit bcb1d8d into trunk Dec 13, 2024
15 checks passed
@bozidarsevo bozidarsevo deleted the issue/14025-remove-reveal-animation-from-orders-list branch December 13, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: order list Related to the order list. type: bug A confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Orders: Reveal animation is glitchy
3 participants