Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete more unused WordPressKit and WordPressAuthenticator code #14794

Merged

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Jan 6, 2025

Builds on top of #14779, see rationale in #14329

The same consideration as #14790 apply: given this is a deletion only PR meant to slim #14779, I'll admin merge it as soon as CI allows it.

@dangermattic
Copy link
Collaborator

dangermattic commented Jan 6, 2025

1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14794-f12f512
Version21.3
Bundle IDcom.automattic.alpha.woocommerce
Commitf12f512
App Center BuildWooCommerce - Prototype Builds #12353
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@mokagio mokagio added this to the 21.5 milestone Jan 6, 2025
@mokagio mokagio added the type: enhancement A request for an enhancement. label Jan 6, 2025
@mokagio mokagio merged commit 8a37081 into mokagio/fold-wordpress-authenticator Jan 6, 2025
17 checks passed
@mokagio mokagio deleted the mokagio/delete-code-wpauth-2 branch January 6, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A request for an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants