Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Brand Updates] Update empty state for some Dashboard cards #14798

Merged

Conversation

hichamboushaba
Copy link
Member

@hichamboushaba hichamboushaba commented Jan 6, 2025

Description

This PR updates the empty state UI of the following dashboard cards: Performance, Top performers Ntkk0ER4hHt5y9KjEGIiGk-fi-3167_7914.
It also updates the stock card empty illustration to match Android by using same empty illustration that we use in product list.

Steps to reproduce

  1. Open the app.
  2. Make sure that you enable the following cards: Performance, Top performers and stock.
  3. Update the filter (or date range) to trigger empty states.

Testing information

Confirm the empty state illustration matches the new design.

Screenshots

Light Dark
Simulator Screenshot - iPhone 16 Pro - 2025-01-06 at 13 53 44 Simulator Screenshot - iPhone 16 Pro - 2025-01-06 at 13 54 01
Simulator Screenshot - iPhone 16 Pro - 2025-01-06 at 18 29 52 Simulator Screenshot - iPhone 16 Pro - 2025-01-06 at 18 29 59

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@hichamboushaba hichamboushaba added category: design Layout and style elements in the UI or user interface, including color and animations. feature: dashboard Related to the My Store dashboard labels Jan 6, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 6, 2025

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14798-07882e3
Version21.2
Bundle IDcom.automattic.alpha.woocommerce
Commit07882e3
App Center BuildWooCommerce - Prototype Builds #12370
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@hichamboushaba hichamboushaba changed the title Task/woo 2.0 dashboard empty [Brand Updates] Update empty state for some Dashboard cards Jan 6, 2025
@hichamboushaba hichamboushaba marked this pull request as ready for review January 6, 2025 12:55
@itsmeichigo itsmeichigo self-assigned this Jan 7, 2025
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on simulator iPhone 16 Pro iOS 18.2 and confirmed that the empty states of the Performance, Top Performers and Stock cards are updated as described.

One minor nit: I see that the empty state of the performance card doesn't have a divider above the "Last updated..." label while the top performers card does. Should we update either of the cards to make them consistent?

image

@hichamboushaba
Copy link
Member Author

One minor nit: I see that the empty state of the performance card doesn't have a divider above the "Last updated..." label while the top performers card does. Should we update either of the cards to make them consistent?

Thanks @itsmeichigo for the review, yes, I noticed this as well, for now I'm trying to wrap the remaining work, so I left this as it was already like this before.

@hichamboushaba hichamboushaba merged commit 585e75c into feature/woo-2.0-brand-updates Jan 7, 2025
15 checks passed
@hichamboushaba hichamboushaba deleted the task/woo-2.0-dashboard-empty branch January 7, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: design Layout and style elements in the UI or user interface, including color and animations. feature: dashboard Related to the My Store dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants