-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Brand Updates] Update empty state for some Dashboard cards #14798
[Brand Updates] Update empty state for some Dashboard cards #14798
Conversation
📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on simulator iPhone 16 Pro iOS 18.2 and confirmed that the empty states of the Performance, Top Performers and Stock cards are updated as described.
One minor nit: I see that the empty state of the performance card doesn't have a divider above the "Last updated..." label while the top performers card does. Should we update either of the cards to make them consistent?
Thanks @itsmeichigo for the review, yes, I noticed this as well, for now I'm trying to wrap the remaining work, so I left this as it was already like this before. |
585e75c
into
feature/woo-2.0-brand-updates
Description
This PR updates the empty state UI of the following dashboard cards: Performance, Top performers Ntkk0ER4hHt5y9KjEGIiGk-fi-3167_7914.
It also updates the stock card empty illustration to match Android by using same empty illustration that we use in product list.
Steps to reproduce
Testing information
Confirm the empty state illustration matches the new design.
Screenshots
RELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: