Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/woo 2.0 other illustrations #14804

Merged

Conversation

hichamboushaba
Copy link
Member

@hichamboushaba hichamboushaba commented Jan 6, 2025

Description

This PR just updates two other illustrations with the new brand colors.

Steps to reproduce

I believe checking the screenshots is enough here.

Testing information

Tested using iPhone 16 Pro simulator, iOS 18.1

Screenshots

Light Dark
Simulator Screenshot - iPhone 16 Pro - 2025-01-06 at 17 58 12 Simulator Screenshot - iPhone 16 Pro - 2025-01-06 at 17 57 49
Simulator Screenshot - iPhone 16 Pro - 2025-01-06 at 18 19 06 Simulator Screenshot - iPhone 16 Pro - 2025-01-06 at 18 19 13

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@hichamboushaba hichamboushaba added the category: design Layout and style elements in the UI or user interface, including color and animations. label Jan 6, 2025
@hichamboushaba hichamboushaba changed the base branch from trunk to feature/woo-2.0-brand-updates January 6, 2025 17:21
@hichamboushaba hichamboushaba marked this pull request as ready for review January 6, 2025 17:24
@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14804-28b5e27
Version21.2
Bundle IDcom.automattic.alpha.woocommerce
Commit28b5e27
App Center BuildWooCommerce - Prototype Builds #12369
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@itsmeichigo itsmeichigo self-assigned this Jan 7, 2025
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested on simulator iPhone SE and confirmed that the assets have been updated as described.

However, the woo-no-store image doesn't seem to update its colors when I switch the appearance mode:

Pre-approving to avoid blocking development.

@hichamboushaba
Copy link
Member Author

However, the woo-no-store image doesn't seem to update its colors when I switch the appearance mode:

Thanks @itsmeichigo for the review, this is an existing issue, and IMO it's a pretty minor one since this screen is not commonly seen, but we can work on fixing it on a separate PR when we have the bandwidth.

@hichamboushaba hichamboushaba merged commit 32fb2a9 into feature/woo-2.0-brand-updates Jan 7, 2025
19 checks passed
@hichamboushaba hichamboushaba deleted the task/woo-2.0-other-illustrations branch January 7, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: design Layout and style elements in the UI or user interface, including color and animations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants