-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Payments] Add IPP support for Puerto Rico #14972
base: trunk
Are you sure you want to change the base?
Conversation
|
Unfortunately, it doesn't work for me as well. I tried to:
Both result in connection failures.
There could be an additional step missing to make it work 🤔 |
Thanks for testing, the 9020 seems to indicate an API error, but it's pretty generic. I'll take a further look 🤔
|
Version |
Closes: #14646
Description
As with the Android counterpart this PR adds IPP support for Puerto Rico by not blocking nor preventing to process a card payment in the mobile client when the store address is set to
PR
.Testing information
Country/State
toPuerto Rico
I was unable to test the full payment flow due to zip code error despite trying multiple PR zip codes (00600, 00940, 00681), which I believe is expected without a fully-functional PR account setup in Stripe/WCPay (context p1737715359181589-slack-C025A8VV728).
Before the changes, we were blocked upon onboarding under a "non-supported country" error through in the client, after the changes we bypass this block and the
invalidPostalCode
(which I'm assuming we can only resolve with a fully-functional PR account) comes from the server:In the same nature, there is no specific
/PR/
URL to acquire a card reader, upon navigating toPayments
>Order Card Reader
it will fallback to the M2 reader:RELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: