-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Release/4.4 back into develop #2378
Conversation
…e more insight about where the error comes from.
…e event might be lost if it is followed by a `fatalError`.
…torage Log messages/crashes in `CoreDataManager` in Storage framework
Generated by 🚫 dangerJS |
@jaclync @shiki @pmusolino Could you take a look at the failing CI build? I assume this is related to #2366, that's why I am pinging you 3, I hope that's correct 🤞
|
@oguzkocer on it. Can I open a new PR on |
Thank you @pmusolino! yes please, but maybe get the PR approved but leave the merge to @loremattei just in case, since he is the release manager. @loremattei I assume this is fine to do because it'll be fixing the tests and won't necessarily need us to publish a new beta. Also, if we don't fix it in the release branch, we'll have the issue in the later PRs as well. If you disagree, we can just change the base branch for the PR, so we should be safe regardless 🤞 |
Here it is: #2380 |
Thanks @oguzkocer! It totally makes sense! |
Fixed failing tests in release 4.4
You can trigger an installable build for these changes by visiting CircleCI here. |
Merge Release/4.4 back into develop
Update release notes:
RELEASE-NOTES.txt
if necessary.