Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and Enhancements: Browser View Layout, Toolbar Improvements & Android Cred Manager #168

Merged
merged 9 commits into from
Nov 29, 2024

Conversation

1311-hack1
Copy link
Contributor

This pull request addresses several issues and introduces features to improve the user experience. Below is a summary of the changes made:

1. Fix: Browser View Layout Issues

Resolved the issue where the browser view was cut off at the top and bottom on web apps.
The browser view now properly fits within the screen bounds, ensuring it doesn't expand beyond the root view.

2. Fix: Space Between Search Bar and Suggestions Box

Removed the unintended space that occasionally appeared between the search toolbar and the suggestions box.

3. Improvement: Floating Bottom Bar Swipe Gesture

Enhanced the floating toolbar to address visibility issues:

  • The Wootzapp bottom bar previously obscured Web elements (e.g., bottom bars or buttons) on certain web pages.
  • Users can now swipe down on the toolbar to disable it, allowing access to elements underneath.
  • Swiping again anywhere on the screen re-enables the toolbar, making it visible again.

4. Update: Default Home Button Settings

  • The home button is now disabled by default in the browser.
  • Users can manually enable the home button via the settings menu.

5. Improvement: Bottom Bar Auto-Hide Feature Disabled

  • The auto-hide behavior of the toolbar during content scrolling has been disabled.
  • This prevents potential UX issues and ensures the toolbar remains visible unless manually hidden by the user.

6. Enabled Android Cred Manager by Default.

Summary of Changes

  1. Manipulated the Viewport meta tag and adjusted the browser view layout to prevent clipping on devices with gesture navigation.
  2. Fixed layout inconsistencies involving the search bar and permissions box.
  3. Implemented swipe gestures for improved floating bottombar visibility control.
  4. Updated default settings to disable the home button.
  5. Disabled the bottombar auto-hide feature for a more consistent experience.

Testing

  1. Verified the browser view remains within screen bounds on various devices and web apps.
  2. Confirmed the removal of unintended spaces in the layout.
  3. Tested the swipe gesture functionality of the floating bottombar to ensure proper enable/disable behavior.
  4. Checked the default home button setting and user-configurable options.
  5. Validated the bottombar's visibility consistency after disabling the auto-hide feature.
screen-20241120-230024.mp4

@pandey019 pandey019 merged commit 7e6ec1b into wootzapp:chromium Nov 29, 2024
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants