Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Prevent Widget Malfunction and App Crash After Extension Removal #217

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

itskartike910
Copy link
Contributor

@itskartike910 itskartike910 commented Jan 12, 2025

#214 Fixed.

This PR addresses an issue where widgets associated with uninstalled extensions remain visible on the New Tab Page (NTP) and cause the app to crash when interacted with. The problem occurs because the widget is not properly removed or disabled after the extension is uninstalled.

Changes Made

1. Widget Cleanup

  • Implemented a mechanism to ensure widgets are removed from the NTP when their corresponding extensions are uninstalled.
  • Added checks to verify the presence of an extension before displaying its widget.

2. Error Handling

  • Enhanced error handling to prevent crashes when interacting with orphaned widgets.
  • Added logging to capture and diagnose unexpected behaviors during widget interactions.

3. UI Updates

  • Updated the UI to immediately reflect the removal of widgets after an extension is uninstalled, ensuring a consistent user experience.

Steps to Verify

  1. Install an extension that includes a widget feature.
    • Verify that the widget appears and functions correctly on the NTP.
  2. Uninstall the extension.
    • Confirm that the widget is removed from the NTP and no longer interacts with the user.
  3. Ensure no crashes occur when attempting to interact with the removed widget.

Testing

  • Manual Testing: Verified the removal of widgets and app stability post-extension uninstallation.
  • Unit Testing: Added unit tests to cover scenarios of widget removal and error handling.

Video

Widget.-.Made.with.Clipchamp.mp4
WidgetIssue.-.Made.with.Clipchamp.mp4

@pandey019 pandey019 closed this Jan 23, 2025
@pandey019 pandey019 reopened this Jan 23, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2025
@pandey019 pandey019 merged commit 0323485 into wootzapp:chromium Jan 23, 2025
2 checks passed
@itskartike910 itskartike910 deleted the crash-fix branch January 29, 2025 08:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants