Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[공통] ArgumentResolver 등록 #44

Closed
wants to merge 2 commits into from

Conversation

Hyeon-Uk
Copy link
Contributor

@Hyeon-Uk Hyeon-Uk commented Aug 13, 2024

💡 다음 이슈를 해결했어요.

Issue Link - #43

  • 기존 등록되지 않은 SessionCustomerArgumentResolverSessionVendorArgumentResolver를 WebConfig에 등록

✅ 셀프 체크리스트

  • 내 코드를 스스로 검토했습니다.
  • 필요한 테스트를 추가했습니다.
  • 모든 테스트를 통과합니다.
  • 브랜치 전략에 맞는 브랜치에 PR을 올리고 있습니다.
  • 커밋 메세지를 컨벤션에 맞추었습니다.
  • wiki를 수정했습니다.

@Hyeon-Uk Hyeon-Uk linked an issue Aug 13, 2024 that may be closed by this pull request
@Hyeon-Uk Hyeon-Uk self-assigned this Aug 13, 2024
@Hyeon-Uk Hyeon-Uk added the ✨ Feature 기능 개발 label Aug 13, 2024
@Hyeon-Uk Hyeon-Uk added this to the 프로토타입 만들기 milestone Aug 13, 2024
@june-777
Copy link
Member

#18 PR의 [feat] SessionArgumentResolver 컴포넌트 등록 및 WebConfiguration 설정 추가 에서 반영한 내용입니다!

누락된 리졸버 설정을 완료해야 실패중인 컨트롤러 단위 테스트가 복구되어, 해당 PR에서 반영하였습니다 🙂

Copy link
Member

@kimhyun5u kimhyun5u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Hyeon-Uk Hyeon-Uk closed this Aug 14, 2024
@Hyeon-Uk
Copy link
Contributor Author

동훤님 말씀대로 깃 전략으로 인해 #3 에서 해결 후 머지시키겠습니다 :)

@Hyeon-Uk Hyeon-Uk deleted the feature/43_Hyeon-Uk_ArgumentResolver_등록 branch August 15, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature 기능 개발
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[기능] ArgumentResolver 등록
3 participants