Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] Payaccount CustomException 수정 #57

Merged
merged 3 commits into from
Aug 15, 2024
Merged

[refactor] Payaccount CustomException 수정 #57

merged 3 commits into from
Aug 15, 2024

Conversation

Hyeon-Uk
Copy link
Contributor

@Hyeon-Uk Hyeon-Uk commented Aug 14, 2024 •
edited
Loading

💡 다음 이슈를 해결했어요.

Issue Link - #56

PayAccount 도메인 및 서비스에서 발생할 수 있는 PayAccount CustomException에 서버 로깅용 메세지를 포함해서 던지도록 CustomException 수정


## ✅ 셀프 체크리스트
  • 내 코드를 스스로 검토했습니다.
  • 필요한 테스트를 추가했습니다.
  • 모든 테스트를 통과합니다.
  • 브랜치 전략에 맞는 브랜치에 PR을 올리고 있습니다.
  • 커밋 메세지를 컨벤션에 맞추었습니다.
  • wiki를 수정했습니다.

@Hyeon-Uk Hyeon-Uk added the 🔨 Refactor 코드 리팩토링 label Aug 14, 2024
@Hyeon-Uk Hyeon-Uk added this to the 프로토타입 만들기 milestone Aug 14, 2024
@Hyeon-Uk Hyeon-Uk self-assigned this Aug 14, 2024
@Hyeon-Uk Hyeon-Uk linked an issue Aug 14, 2024 that may be closed by this pull request
[수정] PayAccount CustomException 수정 #56
Closed
june-777
june-777 approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@june-777 june-777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ^_^

kimhyun5u
kimhyun5u approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@kimhyun5u kimhyun5u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Hyeon-Uk Hyeon-Uk merged commit d4e568a into main Aug 15, 2024
1 check passed
@Hyeon-Uk Hyeon-Uk deleted the feature/56_Hyeon-Uk_payaccount_exception_수정 branch August 15, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dr-KoKo Dr-KoKo Dr-KoKo approved these changes

@june-777 june-777 june-777 approved these changes

@kimhyun5u kimhyun5u kimhyun5u approved these changes

Assignees

@Hyeon-Uk Hyeon-Uk

Labels
🔨 Refactor 코드 리팩토링
Projects
3K1K Project
Status: Done
Milestone
프로토타입 만들기
Development

Successfully merging this pull request may close these issues.

[수정] PayAccount CustomException 수정
4 participants
@Hyeon-Uk @kimhyun5u @june-777 @Dr-KoKo