Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/#80 Project, App View 생성 #106

Merged
merged 15 commits into from
Aug 22, 2024
Merged

Feat/#80 Project, App View 생성 #106

merged 15 commits into from
Aug 22, 2024

Conversation

LuizyHub
Copy link
Member

🚀 작업 내용

  • 프로젝트 검색
image

-없는 프로젝트 검색
image

  • 프로젝트 생성
image
  • 프로젝트 상세 보기
image
  • App 삭제하기
image
  • App 생성하기
image

📸 이슈 번호

✍ 궁금한 점

  • 필요한 필수 로직만 했습니다!
  • 나중엔 회원 기능도 추가해봐요

@LuizyHub LuizyHub added ⭐️ Feat 새로운 기능이나 요청 💇🏻‍♀️ Style 스타일 관련 기능(코드 포맷팅, 세미콜론 누락, 코드 자체의 변경이 없는 경우) labels Aug 22, 2024
@LuizyHub LuizyHub requested a review from a team August 22, 2024 06:24
@LuizyHub LuizyHub self-assigned this Aug 22, 2024
Copy link

Risk Level 2 - /home/runner/work/Team5-Guys/Team5-Guys/logbat_meta/src/main/java/info/logbat_meta/domain/project/domain/App.java

The constructor and static factory method are clear. Ensure that the name and appType are validated to prevent NullPointerExceptions.


Risk Level 2 - /home/runner/work/Team5-Guys/Team5-Guys/logbat_meta/src/main/java/info/logbat_meta/domain/project/presentation/payload/response/AppCommonResponse.java

Ensure that the from method correctly handles null App objects to avoid NullPointerExceptions.


Risk Level 2 - /home/runner/work/Team5-Guys/Team5-Guys/logbat_meta/src/main/java/info/logbat_meta/domain/project/presentation/AppController.java

The createApp method is correctly utilizing the AppService. Ensure that the AppCreateRequest is validated to prevent issues with empty or invalid fields.


🔍✅⚠️


Powered by Code Review GPT

Copy link
Member

@miiiinju1 miiiinju1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Member

@tidavid1 tidavid1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@LuizyHub LuizyHub requested a review from tidavid1 August 22, 2024 08:03
@LuizyHub LuizyHub merged commit 38d1a8e into dev Aug 22, 2024
1 check passed
@tidavid1 tidavid1 deleted the feat/#80 branch August 22, 2024 08:03
LuizyHub added a commit that referenced this pull request Aug 22, 2024
* config: jsp 의존성 추가

* feat: "/" 접속시 "/projects" redirect

* feat: project 검색 페이지 추가

* feat: 프로젝트 상세 보기 페이지 추가

* feat: view controller 추가

* fix: EL 문법 호환

- record -> class
- 불변성을 유지하면서 getter 추가

* feat: JSP 공통 헤더 추가

* config: jstl C tag 라이브러리 추가

* feat: App 도메인에 name 추가

* feat: 프로젝트 검색 페이지 변경

- 프로젝트 생성 버튼 추가

* feat: 프로젝트 생성 페이지 추가

* feat: 프로젝트 상세보기 페이지 변경

- App 생성 버튼 추가
- App 삭제 버튼 추가

* feat: App 생성 페이지 추가

* feat: ViewController 기능 추가

* test: 추가된 App 도메인 name 추가
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐️ Feat 새로운 기능이나 요청 💇🏻‍♀️ Style 스타일 관련 기능(코드 포맷팅, 세미콜론 누락, 코드 자체의 변경이 없는 경우)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants