-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/#80 Project, App View 생성 #106
Conversation
- record -> class - 불변성을 유지하면서 getter 추가
- 프로젝트 생성 버튼 추가
- App 생성 버튼 추가 - App 삭제 버튼 추가
Risk Level 2 - /home/runner/work/Team5-Guys/Team5-Guys/logbat_meta/src/main/java/info/logbat_meta/domain/project/domain/App.java The constructor and static factory method are clear. Ensure that the name and appType are validated to prevent NullPointerExceptions. Risk Level 2 - /home/runner/work/Team5-Guys/Team5-Guys/logbat_meta/src/main/java/info/logbat_meta/domain/project/presentation/payload/response/AppCommonResponse.java Ensure that the from method correctly handles null App objects to avoid NullPointerExceptions. Risk Level 2 - /home/runner/work/Team5-Guys/Team5-Guys/logbat_meta/src/main/java/info/logbat_meta/domain/project/presentation/AppController.java The createApp method is correctly utilizing the AppService. Ensure that the AppCreateRequest is validated to prevent issues with empty or invalid fields. 🔍✅ Powered by Code Review GPT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
* config: jsp 의존성 추가 * feat: "/" 접속시 "/projects" redirect * feat: project 검색 페이지 추가 * feat: 프로젝트 상세 보기 페이지 추가 * feat: view controller 추가 * fix: EL 문법 호환 - record -> class - 불변성을 유지하면서 getter 추가 * feat: JSP 공통 헤더 추가 * config: jstl C tag 라이브러리 추가 * feat: App 도메인에 name 추가 * feat: 프로젝트 검색 페이지 변경 - 프로젝트 생성 버튼 추가 * feat: 프로젝트 생성 페이지 추가 * feat: 프로젝트 상세보기 페이지 변경 - App 생성 버튼 추가 - App 삭제 버튼 추가 * feat: App 생성 페이지 추가 * feat: ViewController 기능 추가 * test: 추가된 App 도메인 name 추가
🚀 작업 내용
-없는 프로젝트 검색
📸 이슈 번호
✍ 궁금한 점