Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teat/#127 memory usage logger add #129

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Teat/#127 memory usage logger add #129

merged 1 commit into from
Aug 27, 2024

Conversation

LuizyHub
Copy link
Member

๐Ÿš€ ์ž‘์—… ๋‚ด์šฉ

  • memory ์‚ฌ์šฉ๋Ÿ‰ logger ์ถ”๊ฐ€

๐Ÿ“ธ ์ด์Šˆ ๋ฒˆํ˜ธ

โœ ๊ถ๊ธˆํ•œ ์ 

  • ์ค‘์ ์ ์œผ๋กœ ๋ด์ค„ ๋‚ด์šฉ
  • ๋ณ€์ˆ˜๋ช… ๊ดœ์ฐฎ๋‚˜์š”
  • ๋กœ์ง์ด ์ข€ ๋”๋Ÿฝ๋‚˜์š”
  • ๊ฐ€๋…์„ฑ์ด ์ข€ ๊ทธ๋Ÿฐ๊ฐ€์š”?

@LuizyHub LuizyHub requested a review from a team August 27, 2024 01:36
@LuizyHub LuizyHub self-assigned this Aug 27, 2024
Copy link
Member

@miiiinju1 miiiinju1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๐Ÿ’ฏ

Copy link

Risk Level 2 - /home/runner/work/Team5-Guys/Team5-Guys/logbat/src/main/java/info/logbat/dev/util/MemoryUsageLogger.java

  1. The logging of memory usage is a good practice, but consider adding a check to avoid logging if the memory usage is below a certain threshold to reduce log noise.

    Example:

    if (usedHeapMemory > threshold) {
        logger.info(...);
    }
  2. Ensure that the fixedRate of 1000 milliseconds is appropriate for your application's performance requirements, as frequent logging can impact performance.


๐Ÿ“๐Ÿ”โš™๏ธ


Powered by Code Review GPT

Copy link
Member

@tidavid1 tidavid1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊น”๊ผผํ•˜๋„ค์š”

@tidavid1 tidavid1 merged commit 4da662d into dev Aug 27, 2024
1 check passed
@tidavid1 tidavid1 deleted the test/#127 branch August 27, 2024 01:44
LuizyHub added a commit that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants