fix: Reddison Lock을 얻을 때 타임아웃이 발생한다면 unlock을 호출하지 않도록 한다. #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HiiWee
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
락을 얻지 못한다면 tryLock에서 대기하다가 타임아웃이 끝나면 예외가 발생합니다. 따라서 무조건적으로 finally를 호출하게 되는데 이때 락을 얻지 못한 상태에서 호출한다면 IllegalMonitorStateException이 발생합니다.
따라서 try-catch문 바깥에서 Lock을 얻도록 변경합니다.
🙋🏻 More
close #343