[자동차 경주] 리팩토링 #2390
Open
[자동차 경주] 리팩토링 #2390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimbaa
reviewed
Nov 26, 2023
| } catch (GlobalException | IllegalArgumentException e) { | ||
| OutputView.printMessage(e.getMessage()); | ||
| return getUserInput(inputReader); | ||
| } |
There was a problem hiding this comment.
수현님 혹시 우테코에서 제공하는 Console 라이브러리 사용안하신 이유가 있으신가요?
JDK에서 제공하는 Random 및 Scanner API 대신 camp.nextstep.edu.missionutils에서 제공하는 Randoms 및 Console API를 사용하여 구현해야 한다.
요구사항에 이게 있어서 여쭤봅니다!
|
|
||
| return cars.stream() | ||
| .map(car -> CarStatusDto.create(car.getName(), car.getPosition())) | ||
| .collect(Collectors.toUnmodifiableList()); |
There was a problem hiding this comment.
수현님 이 부분 찾아보니까
.collect(Collectors.toUnmodifiableList());
를
.toList();
로 바꾸셔도 동일한 코드 인 것 같아요!
default List<T> toList() {
return (List<T>) Collections.unmodifiableList(new ArrayList<>(Arrays.asList(this.toArray())));
}
위는 toList() 의 내부 코드인데 unmodifiableList 를 반환하고 있더군요!
There was a problem hiding this comment.
좀 더 정확히 찾아보려고 chatGPT한테 물어본 결과 입니다!
결론은 저희 우테코 미션에서 자바 17을 사용하니 toList()를 사용해도 되는군요
https://chat.openai.com/share/100db86c-6fc9-4bc6-a590-35de69c0aa02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.