-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[로또] 이승준 미션 제출합니다. #383
Open
1eeSJ
wants to merge
35
commits into
woowacourse-precourse:main
Choose a base branch
from
1eeSJ:1eeSJ
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[로또] 이승준 미션 제출합니다. #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 번호의 범위에 관한 예외 케이스 작성 - 자연수 확인에 관한 예외 케이스 작성 - 문자열로 입력된 경우에 관한 예외 케이스 작성
- 보너스 번호가 당첨 번호와 중복될 경우 - 보너스 번호가 범위를 벗어난 경우
- 잘못된 보너스 번호 입력 시 오류가 발생하고 발생 부분부터 다시 입력되도록 수정
- runException 함수가 아닌 runExceptionBonus를 테스트 하도록 수정
- 로직을 처리할 LottoService 클래스 생성 - 데이터를 저장할 LottoRepository 클래스 생성 - entity를 담당할 Lotto 클래스 파일 위치 변경
- LottoService에서 updateMatch함수로 비교 함수 분리 - LottoRepository에서 match 함수 관리 - match에 필요한 상수값 추가 작성
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.