Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[코드 리뷰용 PR입니다!] - 재구현 스터디 #236

Open
wants to merge 51 commits into
base: main
Choose a base branch
from
Open

[코드 리뷰용 PR입니다!] - 재구현 스터디 #236

wants to merge 51 commits into from

Commits on Oct 28, 2023

  1. �docs: write feature list into README.md

    @getupminaaa
    getupminaaa authored Oct 28, 2023
    Configuration menu
    Copy the full SHA
    b615aea View commit details
    Browse the repository at this point in the history

  2. docs: update README.md

    getupminaaa committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    d0350f4 View commit details
    Browse the repository at this point in the history

  3. docs: update README.MD

    getupminaaa committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    0f1a768 View commit details
    Browse the repository at this point in the history

  4. feat: 경주할 자동차 이름을 입력받는 기능 구현

    getupminaaa committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    18ae353 View commit details
    Browse the repository at this point in the history

  5. feat: 경주할 자동차 이름이 유효한 지 검사하는 기능 구현

    getupminaaa committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    45e1172 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2023

  1. feat: “경주할 자동차 이름을 입력하세요."를 출력하는 기능 구현

    getupminaaa committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    0587a28 View commit details
    Browse the repository at this point in the history

  2. feat: 몇 번의 이동(시도)를 할 지 입력받는 기능 구현

    getupminaaa committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    f7d197c View commit details
    Browse the repository at this point in the history

  3. feat: 입력받는 시도 횟수의 값이 유효한 지 검사하는 기능 구현

    getupminaaa committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    a07cc7c View commit details
    Browse the repository at this point in the history

  4. feat: “시도할 횟수는 몇 회인가요?”를 출력하는 기능 구현

    getupminaaa committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    87bbdd6 View commit details
    Browse the repository at this point in the history

  5. docs: Update README.md

    @getupminaaa
    getupminaaa authored Oct 29, 2023
    Configuration menu
    Copy the full SHA
    b1fb645 View commit details
    Browse the repository at this point in the history

  6. feat: 무작위 수를 생성하는 기능 구현

    getupminaaa committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    24a689a View commit details
    Browse the repository at this point in the history

  7. feat: 자동차가 전진하는지 정지하는지 판단하는 기능 구현

    getupminaaa committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    8838fe9 View commit details
    Browse the repository at this point in the history

  8. docs: Update README.md 

    각 자동차마다 움직인 거리 저장하는 기능 추가
    @getupminaaa
    getupminaaa authored Oct 29, 2023
    Configuration menu
    Copy the full SHA
    1a39005 View commit details
    Browse the repository at this point in the history

  9. fix: regex가 한자리 숫자 이외의 여러 자리 숫자로 구성될 수 있도록 수정

    getupminaaa committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    6885c1a View commit details
    Browse the repository at this point in the history

  10. feat: Car 데이터 클래스 생성

    getupminaaa committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    830e7a0 View commit details
    Browse the repository at this point in the history

  11. feat: Car 데이터 클래스 초기화

    getupminaaa committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    f9389e3 View commit details
    Browse the repository at this point in the history

  12. feat: 각 자동차마다 움직인 거리 저장하는 기능 구현

    getupminaaa committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    a373b2c View commit details
    Browse the repository at this point in the history

  13. feat: 각 차수별 실행 결과를 출력하는 기능 구현

    getupminaaa committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    5ddaae7 View commit details
    Browse the repository at this point in the history

  14. fix: 시도 횟수 입력 값이 1 이상의 정수인지 판단하는 기능 수정 

    regex를 제거하고 조건문으롤 바꿈. regex의 경우 패턴을 중심으로 파악하기 때문에 정확하게 작성하기 어려웠음
    getupminaaa committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    fa304a9 View commit details
    Browse the repository at this point in the history

  15. feat: 우승자를 판별하는 기능 구현

    getupminaaa committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    2226495 View commit details
    Browse the repository at this point in the history

  16. feat: 우승자를 출력하는 기능 구현

    getupminaaa committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    e1e5331 View commit details
    Browse the repository at this point in the history

  17. refactor: getRacingDistances 함수의 depth를 낮추기 위해 함수를 분리

    getupminaaa committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    55d31c6 View commit details
    Browse the repository at this point in the history

  18. refactor: 예외처리와 예외처리 여부를 판별하는 함수를 합침

    getupminaaa committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    68543a9 View commit details
    Browse the repository at this point in the history

  19. test: 이름 중복에 대한 예외처리 테스트 코드 작성

    getupminaaa committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    26dff7b View commit details
    Browse the repository at this point in the history

  20. test: 이름 길이에 대한 예외처리 테스트 코드 작성

    getupminaaa committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    e5107a3 View commit details
    Browse the repository at this point in the history

  21. test: 이름 공백에 대한 예외 처리 테스트 코드 작성

    getupminaaa committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    0e47d26 View commit details
    Browse the repository at this point in the history

  22. test: 시도 횟수 입력에 대한 예외 처리

    getupminaaa committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    c620702 View commit details
    Browse the repository at this point in the history

  23. test: 시도 횟수 입력에 대한 예외 처리 테스트 케이스에 공백 추가

    getupminaaa committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    1b72d7f View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. test: 전진 정지를 판단하는 기능에 대한 테스트 코드 작성

    getupminaaa committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    f15e1d2 View commit details
    Browse the repository at this point in the history

  2. test: 우승자를 판별하는 기능에 대해 테스트코드 작성

    getupminaaa committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    8b7ee71 View commit details
    Browse the repository at this point in the history

  3. refactor: Racing 클래스 파라미터 제거 및 Racing 관련 함수들에 파라미터 추가

    getupminaaa committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    388d7f4 View commit details
    Browse the repository at this point in the history

  4. test: 우승자가 여러 명일 경우에 대해 테스트 코드 작성

    getupminaaa committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    ffbdf01 View commit details
    Browse the repository at this point in the history

  5. test: 자동차가 랜덤값에 따라 움직인 거리를 정상적으로 저장하는 지에 대한 테스트 코드 작성

    getupminaaa committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    c97b43e View commit details
    Browse the repository at this point in the history

  6. test: 최종 우승자를 출력 형식에 맞게 출력하는 지에 대해 테스트 코드 작성

    getupminaaa committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    ae6ac32 View commit details
    Browse the repository at this point in the history

  7. test: 경기 과정을 출력형식에 맞게 출력하는 지에 대해 테스트 코드 작성

    getupminaaa committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    397aa67 View commit details
    Browse the repository at this point in the history

  8. refector: print문을 메서드로 리팩터링

    getupminaaa committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    6bc811a View commit details
    Browse the repository at this point in the history

  9. test: 경기 시작 출력이 형식에 맞는 지에 대해 테스트 코드 작성

    getupminaaa committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    3babfca View commit details
    Browse the repository at this point in the history

  10. test: 시도할 횟수 입력을 안내하는 문구가 출력 형식에 맞는 지에 대해 테스트 코드 작성

    getupminaaa committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    08fb80d View commit details
    Browse the repository at this point in the history

  11. Merge branch 'develop' 

    # Conflicts:
#	docs/README.md
    getupminaaa committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    50e8ace View commit details
    Browse the repository at this point in the history

  12. docs: 0이 아닌 정수를 0보다 큰 정수로 정정

    getupminaaa committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    9bbe173 View commit details
    Browse the repository at this point in the history

  13. refactor: Constant 클래스 생성 및 상수 분리

    getupminaaa committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    4a61b98 View commit details
    Browse the repository at this point in the history

  14. fix: test 클래스에 import 추가

    getupminaaa committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    f358cec View commit details
    Browse the repository at this point in the history

  15. refactor: racing 함수의 출력 부분과 로직 부분 분리

    getupminaaa committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    4a0784d View commit details
    Browse the repository at this point in the history

  16. refactor: 검증 함수를 Validator 클래스로 분리

    getupminaaa committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    9456a40 View commit details
    Browse the repository at this point in the history

  17. refactor: 에러메세지 분리

    getupminaaa committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    beea07d View commit details
    Browse the repository at this point in the history

  18. refactor: main 함수 메서드 분리

    getupminaaa committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    05ee616 View commit details
    Browse the repository at this point in the history

  19. refactor: main함수에 열거된 함수들을 확장함수로 분리

    getupminaaa committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    2a3ea1e View commit details
    Browse the repository at this point in the history

  20. refactor: 게임 시작 시 출력 문구에 "이름은 쉼표(,) 기준으로 구분)" 추가

    getupminaaa committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    3c50f41 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. refactor: 하드코딩한 텍스트를 Const 상수로 분리

    getupminaaa committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    f492c8f View commit details
    Browse the repository at this point in the history

  2. refactor: 디렉터리 구조를 MVC에 맞게 재구현

    getupminaaa committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    c8a1010 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. refactor: MVC구조에 맞게 코드 분리

    getupminaaa committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    76e39ea View commit details
    Browse the repository at this point in the history