Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ControllerAdvice 개편 #950

Merged
merged 4 commits into from
Mar 15, 2023
Merged

feat: ControllerAdvice 개편 #950

merged 4 commits into from
Mar 15, 2023

Conversation

sakjung
Copy link
Collaborator

@sakjung sakjung commented Mar 14, 2023

구현 기능

논의하고 싶은 내용

  • internal server error 발생 시, 클라측에 나가는 메세지 (i.e. 사용자가 볼 메세지) 변경
    • 일시적으로 접속이 원활하지 않습니다. 잠시 후 다시 이용해 주시기 바랍니다.
  • 기존에 ControllerAdvice에서 클라측에 나갈 메세지가 로그로 찍히는 부분이 있었음
    • 우리가 클라측에 나갈만한 안내 메세지를 로그에서 봐서 도움 되는 부분이 없으므로 Exception의 메세지를 대신 찍도록 변경했습니다

Close #948
#949 는 엄밀히 따지면 FE 의 버그 사항이므로 Close 하지 않습니다

@sakjung sakjung self-assigned this Mar 14, 2023
@sakjung sakjung changed the title ControllerAdvice 개편 feat: ControllerAdvice 개편 Mar 14, 2023
@xrabcde xrabcde added 🐛 bug Something isn't working 🕋 backend labels Mar 15, 2023
Copy link
Collaborator

@xrabcde xrabcde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

금방 해결해주셨네염 gooddd

@sakjung sakjung merged commit b2e78ac into dev Mar 15, 2023
@sakjung sakjung deleted the feature/948-jwt-log-level branch March 15, 2023 08:49
@sakjung sakjung mentioned this pull request Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕋 backend 🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BE] Jwt Token 만료 에러 처리 수정
2 participants