fix: 폰트 preload 에러를 개선한다 #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyw0716
added
🚑 버그
feb-dain
requested changes
Oct 26, 2023
Comment on lines
49
to
57
| <link | ||
| href="https://fonts.googleapis.com/css2?family=Noto+Sans+KR:wght@400;500;700&display=swap" | ||
| rel="preload" | ||
| as="font" | ||
| as="style" | ||
| /> | ||
| <link | ||
| href="https://fonts.googleapis.com/css2?family=Noto+Sans+KR:wght@400;500;700&display=swap" | ||
| rel="stylesheet" | ||
| /> |
There was a problem hiding this comment.
Suggested change
| <link | |
| href="https://fonts.googleapis.com/css2?family=Noto+Sans+KR:wght@400;500;700&display=swap" | |
| rel="preload" | |
| as="font" | |
| as="style" | |
| /> | |
| <link | |
| href="https://fonts.googleapis.com/css2?family=Noto+Sans+KR:wght@400;500;700&display=swap" | |
| rel="stylesheet" | |
| /> | |
| <link | |
| href="https://fonts.googleapis.com/css2?family=Noto+Sans+KR:wght@400;500;700&display=swap" | |
| rel="preload" | |
| as="font" | |
| onload=“this.onload=null; this.rel=‘stylesheet’” | |
| /> |
혹시 링크 두 개 대신 이렇게 해도 되는지 확인해줄 수 있나요??
feb-dain
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
preload에 다른 설정도 추가해줘야 제대로 동작하는 것을 확인해 해당 설정을 추가해주었습니다.
🕰️ Actual Time of Completion
1분
🙋🏻 More
참고링크
🚀 Storybook