refactor: 검색 기능을 최적화한다 #928
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 다른 코드들 처럼 hook끼리 모아두기로 결정 [#927]
gabrielyoon7
approved these changes
Nov 14, 2023
kyw0716
requested changes
Nov 26, 2023
| return; | ||
| } | ||
|
|
||
| setUserSearchWord(encodedSearchWord); |
There was a problem hiding this comment.
이전 검색시 사용했던 검색어를 변화하는 현재 검색어와 비교해 같은 검색어는 새로운 요청을 발생시키지 않도록 하기 위해서 새로운 상태를 두어 해당 값을 캐시로 활용하고 계신거 같네요! 제가 이해한 내용이 맞다면 추가적인 상태를 늘려 훅의 복잡도가 높아질 여지가 있진 않을까 하는 생각이 듭니다.
현재 코드를 보면 검색 결과에 대한 쿼리를 등록하고 있으므로 해당 쿼리키에 해당하는 캐시 값이 있는지 여부를 통해 이전에 검색했던 값인지를 알아올 수도 있을 것 같아요! 아래 링크에 있는 메서드(queryClient.getQueryData)를 활용해도 괜찮을 것 같습니다 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
🕰️ Actual Time of Completion
🙋🏻 More
close #927
🚀 Storybook