refactor: Dao 대신 Repository 계층에 의존하도록 수정 - JdbcRepository 추상화

backend/kirikiri/src/main/java/co/kirikiri/persistence/goalroom/GoalRoomMemberJdbcRepository.java

@@ -0,0 +1,9 @@
+package co.kirikiri.persistence.goalroom;
+
+import co.kirikiri.domain.goalroom.GoalRoomMember;
+import java.util.List;
+
+public interface GoalRoomMemberJdbcRepository {
+
+    void saveAllInBatch(final List<GoalRoomMember> goalRoomMembers);
+}

backend/kirikiri/src/main/java/co/kirikiri/persistence/goalroom/GoalRoomMemberDao.java → backend/kirikiri/src/main/java/co/kirikiri/persistence/goalroom/GoalRoomMemberJdbcRepositoryImpl.java

@@ -6,17 +6,18 @@
 import org.springframework.stereotype.Repository;
 
 @Repository
-public class GoalRoomMemberDao {
+public class GoalRoomMemberJdbcRepositoryImpl implements GoalRoomMemberJdbcRepository {
 
     private final JdbcTemplate jdbcTemplate;
 
-    public GoalRoomMemberDao(final JdbcTemplate jdbcTemplate) {
+    public GoalRoomMemberJdbcRepositoryImpl(final JdbcTemplate jdbcTemplate) {
         this.jdbcTemplate = jdbcTemplate;
     }
 
-    public void saveAll(final List<GoalRoomMember> goalRoomMembers) {
+    @Override
+    public void saveAllInBatch(final List<GoalRoomMember> goalRoomMembers) {
         final String sql = "INSERT INTO goal_room_member "
-                + "(goal_room_id, member_id, role, joined_at, accomplishment_rate)"
+                + "(goal_room_id, member_id, role, joined_at, accomplishment_rate) "
                 + "VALUES (?, ?, ?, ?, ?)";
         jdbcTemplate.batchUpdate(sql, goalRoomMembers, goalRoomMembers.size(), ((ps, goalRoomMember) -> {
             ps.setLong(1, goalRoomMember.getGoalRoom().getId());

backend/kirikiri/src/main/java/co/kirikiri/persistence/goalroom/GoalRoomMemberRepository.java

@@ -3,13 +3,14 @@
 import co.kirikiri.domain.goalroom.GoalRoom;
 import co.kirikiri.domain.goalroom.GoalRoomMember;
 import co.kirikiri.domain.member.vo.Identifier;
+import java.util.List;
+import java.util.Optional;
 import org.springframework.data.jpa.repository.JpaRepository;
 import org.springframework.data.jpa.repository.Query;
 import org.springframework.data.repository.query.Param;
-import java.util.List;
-import java.util.Optional;
 
-public interface GoalRoomMemberRepository extends JpaRepository<GoalRoomMember, Long>, GoalRoomMemberQueryRepository {
+public interface GoalRoomMemberRepository extends JpaRepository<GoalRoomMember, Long>,
+        GoalRoomMemberQueryRepository, GoalRoomMemberJdbcRepository {
 
     @Query("select gm from GoalRoomMember gm "
             + "inner join fetch gm.goalRoom g "

backend/kirikiri/src/main/java/co/kirikiri/service/scheduler/GoalRoomScheduler.java

@@ -4,7 +4,7 @@
 import co.kirikiri.domain.goalroom.GoalRoom;
 import co.kirikiri.domain.goalroom.GoalRoomMember;
 import co.kirikiri.domain.goalroom.GoalRoomPendingMember;
-import co.kirikiri.persistence.goalroom.GoalRoomMemberDao;
+import co.kirikiri.persistence.goalroom.GoalRoomMemberRepository;
 import co.kirikiri.persistence.goalroom.GoalRoomPendingMemberRepository;
 import co.kirikiri.persistence.goalroom.GoalRoomRepository;
 import co.kirikiri.service.aop.ExceptionConvert;
@@ -23,7 +23,7 @@ public class GoalRoomScheduler {
 
     private final GoalRoomRepository goalRoomRepository;
     private final GoalRoomPendingMemberRepository goalRoomPendingMemberRepository;
-    private final GoalRoomMemberDao goalRoomMemberDao;
+    private final GoalRoomMemberRepository goalRoomMemberRepository;
 
     @Scheduled(cron = "0 0 0 * * *")
     public void startGoalRooms() {
@@ -38,7 +38,7 @@ public void startGoalRooms() {
 
     private void saveGoalRoomMemberFromPendingMembers(final List<GoalRoomPendingMember> goalRoomPendingMembers) {
         final List<GoalRoomMember> goalRoomMembers = makeGoalRoomMembers(goalRoomPendingMembers);
-        goalRoomMemberDao.saveAll(goalRoomMembers);
+        goalRoomMemberRepository.saveAllInBatch(goalRoomMembers);
         final List<Long> ids = makeGoalRoomPendingMemberIds(goalRoomPendingMembers);
         goalRoomPendingMemberRepository.deleteAllByIdIn(ids);
     }

backend/kirikiri/src/test/java/co/kirikiri/integration/GoalRoomSchedulerIntegrationTest.java

@@ -26,17 +26,17 @@
 import co.kirikiri.integration.helper.InitIntegrationTest;
 import co.kirikiri.persistence.goalroom.GoalRoomMemberRepository;
 import co.kirikiri.persistence.goalroom.GoalRoomPendingMemberRepository;
-import co.kirikiri.service.scheduler.GoalRoomScheduler;
 import co.kirikiri.service.dto.auth.request.LoginRequest;
 import co.kirikiri.service.dto.goalroom.request.GoalRoomCreateRequest;
 import co.kirikiri.service.dto.goalroom.request.GoalRoomRoadmapNodeRequest;
 import co.kirikiri.service.dto.member.request.GenderType;
 import co.kirikiri.service.dto.member.request.MemberJoinRequest;
 import co.kirikiri.service.dto.member.response.MemberGoalRoomResponse;
 import co.kirikiri.service.dto.roadmap.response.RoadmapResponse;
-import org.junit.jupiter.api.Test;
+import co.kirikiri.service.scheduler.GoalRoomScheduler;
 import java.io.IOException;
 import java.util.List;
+import org.junit.jupiter.api.Test;
 
 class GoalRoomSchedulerIntegrationTest extends InitIntegrationTest {
 

backend/kirikiri/src/test/java/co/kirikiri/integration/helper/TestTransactionService.java

@@ -88,7 +88,7 @@ public TestTransactionService(final GoalRoomRepository goalRoomRepository,
     }
 
     public void 골룸_멤버를_저장한다(final List<GoalRoomMember> 골룸_멤버_리스트) {
-        goalRoomMemberRepository.saveAll(골룸_멤버_리스트);
+        goalRoomMemberRepository.saveAllInBatch(골룸_멤버_리스트);
     }
 
     public void 골룸의_상태와_종료날짜를_변경한다(final Long 골룸_아이디, final GoalRoomStatus 골룸_상태, final LocalDate 변경할_종료날짜) {

backend/kirikiri/src/test/java/co/kirikiri/persistence/goalroom/CheckFeedRepositoryTest.java

@@ -34,10 +34,10 @@
 import co.kirikiri.persistence.member.MemberRepository;
 import co.kirikiri.persistence.roadmap.RoadmapCategoryRepository;
 import co.kirikiri.persistence.roadmap.RoadmapRepository;
-import org.junit.jupiter.api.Test;
 import java.time.LocalDate;
 import java.time.LocalDateTime;
 import java.util.List;
+import org.junit.jupiter.api.Test;
 
 @RepositoryTest
 class CheckFeedRepositoryTest {
@@ -86,7 +86,7 @@ public CheckFeedRepositoryTest(final MemberRepository memberRepository,
         final GoalRoomMember leader = new GoalRoomMember(GoalRoomRole.LEADER, LocalDateTime.now(), goalRoom, creator);
         final GoalRoomMember joinedMember = new GoalRoomMember(GoalRoomRole.FOLLOWER, LocalDateTime.now(), goalRoom,
                 member);
-        goalRoomMemberRepository.saveAll(List.of(leader, joinedMember));
+        goalRoomMemberRepository.saveAllInBatch(List.of(leader, joinedMember));
 
         final GoalRoomRoadmapNode goalRoomRoadmapNode = goalRoom.getGoalRoomRoadmapNodes().getValues().get(0);
         인증_피드를_저장한다(goalRoomRoadmapNode, joinedMember);
@@ -120,7 +120,7 @@ public CheckFeedRepositoryTest(final MemberRepository memberRepository,
         final GoalRoomMember leader = new GoalRoomMember(GoalRoomRole.LEADER, LocalDateTime.now(), goalRoom, creator);
         final GoalRoomMember joinedMember = new GoalRoomMember(GoalRoomRole.FOLLOWER, LocalDateTime.now(), goalRoom,
                 member);
-        goalRoomMemberRepository.saveAll(List.of(leader, joinedMember));
+        goalRoomMemberRepository.saveAllInBatch(List.of(leader, joinedMember));
 
         final GoalRoomRoadmapNode goalRoomRoadmapNode = goalRoom.getGoalRoomRoadmapNodes().getValues().get(0);
         인증_피드를_저장한다(goalRoomRoadmapNode, joinedMember);
@@ -151,7 +151,7 @@ public CheckFeedRepositoryTest(final MemberRepository memberRepository,
         final GoalRoomMember leader = new GoalRoomMember(GoalRoomRole.LEADER, LocalDateTime.now(), goalRoom, creator);
         final GoalRoomMember joinedMember = new GoalRoomMember(GoalRoomRole.FOLLOWER, LocalDateTime.now(), goalRoom,
                 member);
-        goalRoomMemberRepository.saveAll(List.of(leader, joinedMember));
+        goalRoomMemberRepository.saveAllInBatch(List.of(leader, joinedMember));
 
         final GoalRoomRoadmapNode goalRoomRoadmapNode1 = goalRoom.getGoalRoomRoadmapNodes().getValues().get(0);
         final GoalRoomRoadmapNode goalRoomRoadmapNode2 = goalRoom.getGoalRoomRoadmapNodes().getValues().get(1);
@@ -188,7 +188,7 @@ public CheckFeedRepositoryTest(final MemberRepository memberRepository,
                 member);
         final GoalRoomMember otherLeader = new GoalRoomMember(GoalRoomRole.LEADER, LocalDateTime.now(), goalRoom2,
                 creator);
-        goalRoomMemberRepository.saveAll(List.of(leader, joinedMember));
+        goalRoomMemberRepository.saveAllInBatch(List.of(leader, joinedMember));
 
         final GoalRoomRoadmapNode goalRoomRoadmapNode1 = goalRoom1.getGoalRoomRoadmapNodes().getValues().get(0);
         final GoalRoomRoadmapNode goalRoomRoadmapNode2 = goalRoom1.getGoalRoomRoadmapNodes().getValues().get(1);
@@ -226,7 +226,7 @@ public CheckFeedRepositoryTest(final MemberRepository memberRepository,
         final GoalRoomMember leader = new GoalRoomMember(GoalRoomRole.LEADER, LocalDateTime.now(), goalRoom, creator);
         final GoalRoomMember joinedMember = new GoalRoomMember(GoalRoomRole.FOLLOWER, LocalDateTime.now(), goalRoom,
                 member);
-        goalRoomMemberRepository.saveAll(List.of(leader, joinedMember));
+        goalRoomMemberRepository.saveAllInBatch(List.of(leader, joinedMember));
 
         final GoalRoomRoadmapNode goalRoomRoadmapNode1 = goalRoom.getGoalRoomRoadmapNodes().getValues().get(0);
         final GoalRoomRoadmapNode goalRoomRoadmapNode2 = goalRoom.getGoalRoomRoadmapNodes().getValues().get(1);
@@ -269,7 +269,7 @@ public CheckFeedRepositoryTest(final MemberRepository memberRepository,
         final GoalRoomMember leader = new GoalRoomMember(GoalRoomRole.LEADER, LocalDateTime.now(), goalRoom, creator);
         final GoalRoomMember joinedMember = new GoalRoomMember(GoalRoomRole.FOLLOWER, LocalDateTime.now(), goalRoom,
                 member);
-        goalRoomMemberRepository.saveAll(List.of(leader, joinedMember));
+        goalRoomMemberRepository.saveAllInBatch(List.of(leader, joinedMember));
 
         final GoalRoomRoadmapNode goalRoomRoadmapNode1 = goalRoom.getGoalRoomRoadmapNodes().getValues().get(0);
         final GoalRoomRoadmapNode goalRoomRoadmapNode2 = goalRoom.getGoalRoomRoadmapNodes().getValues().get(1);
@@ -303,7 +303,7 @@ public CheckFeedRepositoryTest(final MemberRepository memberRepository,
         final GoalRoomMember leader = new GoalRoomMember(GoalRoomRole.LEADER, LocalDateTime.now(), goalRoom, creator);
         final GoalRoomMember joinedMember = new GoalRoomMember(GoalRoomRole.FOLLOWER, LocalDateTime.now(), goalRoom,
                 member);
-        goalRoomMemberRepository.saveAll(List.of(leader, joinedMember));
+        goalRoomMemberRepository.saveAllInBatch(List.of(leader, joinedMember));
 
         final GoalRoomRoadmapNode goalRoomRoadmapNode1 = goalRoom.getGoalRoomRoadmapNodes().getValues().get(0);
         final GoalRoomRoadmapNode goalRoomRoadmapNode2 = goalRoom.getGoalRoomRoadmapNodes().getValues().get(1);
@@ -348,7 +348,7 @@ public CheckFeedRepositoryTest(final MemberRepository memberRepository,
         final GoalRoomMember leader = new GoalRoomMember(GoalRoomRole.LEADER, LocalDateTime.now(), goalRoom, creator);
         final GoalRoomMember joinedMember = new GoalRoomMember(GoalRoomRole.FOLLOWER, LocalDateTime.now(), goalRoom,
                 member);
-        goalRoomMemberRepository.saveAll(List.of(leader, joinedMember));
+        goalRoomMemberRepository.saveAllInBatch(List.of(leader, joinedMember));
 
         final GoalRoomRoadmapNode goalRoomRoadmapNode1 = goalRoom.getGoalRoomRoadmapNodes().getValues().get(0);
         final GoalRoomRoadmapNode goalRoomRoadmapNode2 = goalRoom.getGoalRoomRoadmapNodes().getValues().get(1);
@@ -407,7 +407,7 @@ public CheckFeedRepositoryTest(final MemberRepository memberRepository,
         final GoalRoomMember leader = new GoalRoomMember(GoalRoomRole.LEADER, LocalDateTime.now(), goalRoom, creator);
         final GoalRoomMember joinedMember = new GoalRoomMember(GoalRoomRole.FOLLOWER, LocalDateTime.now(), goalRoom,
                 member);
-        goalRoomMemberRepository.saveAll(List.of(leader, joinedMember));
+        goalRoomMemberRepository.saveAllInBatch(List.of(leader, joinedMember));
 
         final GoalRoomRoadmapNode goalRoomRoadmapNode1 = goalRoom.getGoalRoomRoadmapNodes().getValues().get(0);
         final GoalRoomRoadmapNode goalRoomRoadmapNode2 = goalRoom.getGoalRoomRoadmapNodes().getValues().get(1);

backend/kirikiri/src/test/java/co/kirikiri/persistence/goalroom/GoalRoomMemberRepositoryTest.java

@@ -33,12 +33,12 @@
 import co.kirikiri.persistence.member.MemberRepository;
 import co.kirikiri.persistence.roadmap.RoadmapCategoryRepository;
 import co.kirikiri.persistence.roadmap.RoadmapRepository;
-import org.assertj.core.api.Assertions;
-import org.junit.jupiter.api.Test;
 import java.time.LocalDate;
 import java.time.LocalDateTime;
 import java.util.List;
 import java.util.Optional;
+import org.assertj.core.api.Assertions;
+import org.junit.jupiter.api.Test;
 
 @RepositoryTest
 class GoalRoomMemberRepositoryTest {
@@ -296,11 +296,13 @@ public GoalRoomMemberRepositoryTest(final MemberRepository memberRepository,
     private Member 크리에이터를_저장한다() {
         final MemberImage memberImage = new MemberImage("originalFileName", "serverFilePath", ImageContentType.JPG);
         final MemberProfile memberProfile = new MemberProfile(Gender.MALE, "[email protected]");
-        final Member creator = new Member(1L, new Identifier("cokirikiri"), null, new EncryptedPassword(new Password("password1!")), new Nickname("코끼리"), memberImage, memberProfile);
+        final Member creator = new Member(1L, new Identifier("cokirikiri"), null,
+                new EncryptedPassword(new Password("password1!")), new Nickname("코끼리"), memberImage, memberProfile);
         return memberRepository.save(creator);
     }
 
-    private Member 사용자를_생성한다(final String identifier, final String password, final String nickname, final String email) {
+    private Member 사용자를_생성한다(final String identifier, final String password, final String nickname,
+                             final String email) {
         final MemberProfile memberProfile = new MemberProfile(Gender.MALE, email);
         final Member member = new Member(new Identifier(identifier),
                 new EncryptedPassword(new Password(password)), new Nickname(nickname),

backend/kirikiri/src/test/java/co/kirikiri/persistence/goalroom/GoalRoomToDoCheckRepositoryTest.java

@@ -30,10 +30,10 @@
 import co.kirikiri.persistence.member.MemberRepository;
 import co.kirikiri.persistence.roadmap.RoadmapCategoryRepository;
 import co.kirikiri.persistence.roadmap.RoadmapRepository;
-import org.junit.jupiter.api.Test;
 import java.time.LocalDate;
 import java.time.LocalDateTime;
 import java.util.List;
+import org.junit.jupiter.api.Test;
 
 @RepositoryTest
 class GoalRoomToDoCheckRepositoryTest {

backend/kirikiri/src/test/java/co/kirikiri/persistence/roadmap/RoadmapRepositoryTest.java

@@ -37,11 +37,11 @@
 import co.kirikiri.persistence.goalroom.GoalRoomRepository;
 import co.kirikiri.persistence.helper.RepositoryTest;
 import co.kirikiri.persistence.member.MemberRepository;
-import org.junit.jupiter.api.Test;
 import java.time.LocalDate;
 import java.time.LocalDateTime;
 import java.util.List;
 import java.util.Optional;
+import org.junit.jupiter.api.Test;
 
 @RepositoryTest
 class RoadmapRepositoryTest {
@@ -249,13 +249,13 @@ public RoadmapRepositoryTest(final MemberRepository memberRepository,
         // gameRoadmap2 : 참가인원 1명
         final List<GoalRoomMember> gameRoadmap2GoalRoomMembers = List.of(
                 new GoalRoomMember(GoalRoomRole.LEADER, LocalDateTime.now(), gameRoadmap2GoalRoom, creator));
-        goalRoomMemberRepository.saveAll(gameRoadmap2GoalRoomMembers);
+        goalRoomMemberRepository.saveAllInBatch(gameRoadmap2GoalRoomMembers);
 
         // travelRoadmap : 참가인원 2명
         final List<GoalRoomMember> travelRoadmapGoalRoomMembers = List.of(
                 new GoalRoomMember(GoalRoomRole.LEADER, LocalDateTime.now(), travelRoadmapGoalRoom, creator),
                 new GoalRoomMember(GoalRoomRole.FOLLOWER, LocalDateTime.now(), travelRoadmapGoalRoom, follower));
-        goalRoomMemberRepository.saveAll(travelRoadmapGoalRoomMembers);
+        goalRoomMemberRepository.saveAllInBatch(travelRoadmapGoalRoomMembers);
 
         final RoadmapCategory category = null;
         final RoadmapOrderType orderType = RoadmapOrderType.PARTICIPANT_COUNT;

backend/kirikiri/src/test/java/co/kirikiri/service/GoalRoomSchedulerTest.java

@@ -34,7 +34,7 @@
 import co.kirikiri.domain.roadmap.RoadmapNodeImage;
 import co.kirikiri.domain.roadmap.RoadmapNodeImages;
 import co.kirikiri.domain.roadmap.RoadmapNodes;
-import co.kirikiri.persistence.goalroom.GoalRoomMemberDao;
+import co.kirikiri.persistence.goalroom.GoalRoomMemberRepository;
 import co.kirikiri.persistence.goalroom.GoalRoomPendingMemberRepository;
 import co.kirikiri.persistence.goalroom.GoalRoomRepository;
 import co.kirikiri.service.scheduler.GoalRoomScheduler;
@@ -60,9 +60,9 @@ class GoalRoomSchedulerTest {
 
     @Mock
     private GoalRoomPendingMemberRepository goalRoomPendingMemberRepository;
-
+    
     @Mock
-    private GoalRoomMemberDao goalRoomMemberDao;
+    private GoalRoomMemberRepository goalRoomMemberRepository;
 
     @InjectMocks
     private GoalRoomScheduler goalRoomScheduler;