[feat/CK-149] 골룸 인증피드 내부 전체 인증피드 도출 로직을 구현한다 #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh981013s
added
feature 🔅
jw-r
reviewed
Aug 8, 2023
| id='fileInput' | ||
| type='file' | ||
| onChange={handleImageChange} | ||
| style={{ display: 'none' }} |
There was a problem hiding this comment.
으으 이거 진짜진짜 어떤 느낌인지 아는데ㅠㅠ
그래도 스타일은 styled component에서 주는걸로 통일시키는 것은 어떨까요?
| </S.InputFieldWrapper> | ||
| <TextCount maxCount={250} currentCount={value.length} /> | ||
| <S.ErrorMessage>{errorMessage}</S.ErrorMessage> | ||
| <S.CertificationSubmitButton type='submit'> |
There was a problem hiding this comment.
type='submit'은 없어도 무방할 것 같아요🤩
| checkFeed: CheckFeedType; | ||
| }; | ||
|
|
||
| export type GoalRoomCertificationFeedsResponse = Array<CertificationFeedType>; |
There was a problem hiding this comment.
Array<CertificationFeedType>
CertificationFeedType[]
둘 중 어떻게 작성할지 팀 컨벤션으로 이야기해봐도 좋을 것 같아요!
현재는 CertificationFeedType[]와 같이 작성된 타입이 많은데, 이걸로 통일시키는 것은 어떨까요?
NaveOWO
requested changes
Aug 9, 2023
변경 적용했습니다~~! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 작업 이슈 번호
CK-149
✨ 작업 내용
💬 리뷰어에게 남길 멘트
잘부탁드립니다.
🚀 요구사항 분석