[feat/CK-210] 로드맵 디테일 페이지의 UI를 개편한다. #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jw-r
added
feature 🔅
NaveOWO
approved these changes
Sep 30, 2023
| roadmapInfo: RoadmapDetailType; | ||
| }; | ||
|
|
||
| const Introduction = ({ roadmapInfo }: IntroductionType) => { |
There was a problem hiding this comment.
타입 네이밍 컨벤션은 InfoductionProps 에요!!
| }, []); | ||
|
|
||
| const toggleExpand = () => { | ||
| setIsExpanded(!isExpanded); |
There was a problem hiding this comment.
사소한 부분이지만 setIsExpanded((prev) => !prev) 가 더 정확한 표현인 것 같아요~!;
sh981013s
approved these changes
Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 작업 이슈 번호
CK-210
✨ 작업 내용
💬 리뷰어에게 남길 멘트
모바일 환경에서는 사진과 로드맵의 메타 정보(난이도, 카테고리 등)가 보이지 않는 것을 확인할 수 있습니다.
이유는 다음과 같습니다.
왜인지 개행이 적용되지 않아서 조금 지저분해 보이는군요😭
PC 환경
모바일 환경
더 보기 버튼 활성화 상태 및 No Image
2023-10-01.12.39.07.mov
잘 부탁드립니다~!