Skip to content

Commit

Permalink
chore: 리베이스로 인한 버그 수정
Browse files Browse the repository at this point in the history
  • Loading branch information
Dahyeeee committed Sep 11, 2023
1 parent d932de5 commit eb3c8c8
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 11 deletions.
6 changes: 3 additions & 3 deletions frontend/src/pages/TripPage/TripMobilePage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import TripInformation from '@components/common/TripInformation/TripInformation'
import TripMap from '@components/common/TripMap/TripMap';

import { useTripQuery } from '@hooks/api/useTripQuery';
import { useTripDates } from '@hooks/trip/useTripDates';
import { useTrip } from '@hooks/trip/useTrip';

import { formatMonthDate } from '@utils/formatter';

Expand All @@ -31,7 +31,7 @@ const TripMobilePage = () => {
tripData.dayLogs[0].id
);
const selectedDayLog = tripData.dayLogs.find((log) => log.id === selectedDayLogId)!;
const { dates } = useTripDates(Number(tripId));
const { dates } = useTrip(Number(tripId));

const places = useMemo(
() =>
Expand All @@ -48,7 +48,7 @@ const TripMobilePage = () => {
return (
<Flex styles={{ direction: 'column' }}>
<section css={containerStyling}>
<TripInformation isEditable={false} {...tripData} />
<TripInformation tripId={Number(tripId)} isEditable={false} />
<section css={contentStyling}>
<Tabs>
{dates.map((date, index) => {
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/pages/TripPage/TripPage.style.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export const contentStyling = css({
padding: `${Theme.spacer.spacing4} 50px`,

'@media screen and (max-width: 600px)': {
padding: Theme.spacer.spacing4,
padding: `${Theme.spacer.spacing3} ${Theme.spacer.spacing4} 0 ${Theme.spacer.spacing4}`,
},

'& > ul': {
Expand Down
3 changes: 1 addition & 2 deletions frontend/src/router/AppRouter.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import { useRecoilValue } from 'recoil';
import ExpensePageSkeleton from '@pages/ExpensePage/ExpensePageSkeleton';
import NotFoundPage from '@pages/NotFoundPage/NotFoundPage';
import RedirectPage from '@pages/RedirectPage/RedirectPage';
import TripMobilePage from '@pages/TripPage/TripMobilePage';
import TripPageSkeleton from '@pages/TripPage/TripPageSkeleton';
import TripsPageSkeleton from '@pages/TripsPage/TripsPageSkeleton';

Expand Down Expand Up @@ -43,7 +42,7 @@ const AppRouter = () => {
path: PATH.TRIP(':tripId'),
element: (
<Suspense fallback={<TripPageSkeleton />}>
{isMobile ? <TripMobilePage /> : <Lazy.TripPage />}
{isMobile ? <Lazy.TripMobilePage /> : <Lazy.TripPage />}
</Suspense>
),
},
Expand Down
4 changes: 4 additions & 0 deletions frontend/src/router/lazy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ export const TripPage = lazy(
() => import(/* webpackChunkName: "TripPage" */ '@pages/TripPage/TripPage')
);

export const TripMobilePage = lazy(
() => import(/* webpackChunkName: "TripPage" */ '@pages/TripPage/TripMobilePage')
);

export const TripsPage = lazy(
() => import(/* webpackChunkName: "TripsPage" */ '@pages/TripsPage/TripsPage')
);
7 changes: 2 additions & 5 deletions frontend/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ const path = require('path');
const webpack = require('webpack');
const { BundleAnalyzerPlugin } = require('webpack-bundle-analyzer');
const CompressionPlugin = require('compression-webpack-plugin');
const CopyPlugin = require('copy-webpack-plugin');

const prod = process.env.NODE_ENV === 'production';

Expand All @@ -29,8 +30,6 @@ const plugins = [
];

if (!prod) {
const CopyPlugin = require('copy-webpack-plugin');

plugins.push(
new CopyPlugin({
patterns: [{ from: 'public/mockServiceWorker.js', to: '' }],
Expand All @@ -42,9 +41,7 @@ module.exports = {
mode: prod ? 'production' : 'development',
devtool: prod ? 'hidden-source-map' : 'eval',
entry: './src/index.tsx',
resolve: {
extensions: ['.js', '.jsx', '.ts', '.tsx'],
},

module: {
rules: [
{
Expand Down

0 comments on commit eb3c8c8

Please sign in to comment.