Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

여행 정보(이름, 날짜, 도시, 설명, 대표사진) 수정 모달 구현 #132

Merged
merged 20 commits into from
Jul 27, 2023
Merged

여행 정보(이름, 날짜, 도시, 설명, 대표사진) 수정 모달 구현 #132

merged 20 commits into from
Jul 27, 2023

Conversation

Dahyeeee
Copy link
Collaborator

📄 Summary

image
image

🙋🏻 More

변한 파일이 많아보이나 이름변경한 것들이 있으니 그것들은 가볍게 넘기셔도 됩니당.

로직이 복잡해보이신다면... 맞습니다.ㅎㅎㅎㅎ
질문환영~~~

close #69

@Dahyeeee
feat:여행정보 수정 모달 마크업
ede2e1d
@Dahyeeee
feat:여행정보 수정 서버로 put하는 로직 작성
3a2a277
@Dahyeeee
refactor: 필수입력 마크들어가도록 수정, 모달 불필요한 padding삭제
ee623e2
@Dahyeeee
Merge branch 'develop' of https://github.com/woowacourse-teams/2023-h…
cd68319 
…ang-log into feature/#69
@Dahyeeee
feat:여행정보 수정 가능 기능
7385eb5
@Dahyeeee
feat:서버로 수정한 정보 보내는 기능
d7cfd54
@Dahyeeee
feat:기간이 기존값보다 작을 때 경고 출력기능
238ecd2
@Dahyeeee
refactor: rename 함수
0ffc2f6
@Dahyeeee
refactor:기간 줄어드는 경고 삭제
c401fce
@Dahyeeee
refactor: 수정모달 기간 조정에 관한 경고문구 삽입
93f2955
@Dahyeeee
refactor:도시 미선택시 경고문구 출력
245a795
@Dahyeeee
Merge branch 'develop' of https://github.com/woowacourse-teams/2023-h…
4c3ce0a 
…ang-log into feature/#69
@Dahyeeee Dahyeeee self-assigned this Jul 25, 2023
@Dahyeeee Dahyeeee added ✨ Feature FE-Service 행록 서비스 프론트엔드 labels Jul 25, 2023
@Dahyeeee Dahyeeee added this to the 3차 스프린트 milestone Jul 25, 2023
ashleysyheo
ashleysyheo requested changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@ashleysyheo ashleysyheo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헤다 수고했습니다! 🔥

리뷰 확인 부탁드려요!!!! 😊

frontend/src/types/trip.ts Outdated Show resolved Hide resolved
frontend/src/components/trip/TripInfoEditModal/TripInfoEditModal.tsx Outdated Show resolved Hide resolved
frontend/src/components/trip/TripInfoEditModal/TripInfoEditModal.tsx Outdated Show resolved Hide resolved
frontend/src/components/trip/TripInfoEditModal/TripInfoEditModal.tsx Outdated Show resolved Hide resolved
frontend/src/components/trip/TripInfoEditModal/TripInfoEditModal.tsx Outdated Show resolved Hide resolved
frontend/src/hooks/api/useEditTripMutation.ts Outdated Show resolved Hide resolved
frontend/src/hooks/trip/useTripInfoForm.ts Outdated Show resolved Hide resolved
frontend/src/hooks/trip/useTripInfoForm.ts Outdated Show resolved Hide resolved
frontend/src/hooks/trip/useTripInfoForm.ts Outdated Show resolved Hide resolved
frontend/src/hooks/trip/useTripInfoForm.ts Outdated Show resolved Hide resolved
dladncks1217
dladncks1217 requested changes Jul 25, 2023
View reviewed changes
Copy link
Member

@dladncks1217 dladncks1217 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨어요 헤다~! 💯💯💯
그런데 버그를 하나 발견했어요!
뱃지의 x말고 몸통 부분을 누르면 아래와 같이 되어버립니다...🥲
이거랑 코멘트 확인 한번만 부탁드릴게요!👍

스크린샷 2023-07-25 오후 2 08 08

frontend/src/components/newTrip/NewTripForm/NewTripForm.tsx Outdated Show resolved Hide resolved
frontend/src/components/trip/TripInfoEditModal/TripInfoEditModal.tsx Outdated Show resolved Hide resolved
frontend/src/api/trip/putTrip.ts Outdated Show resolved Hide resolved
frontend/src/components/common/CitySearchBar/CitySearchBar.tsx Show resolved Hide resolved
frontend/src/components/newTrip/NewTripForm/NewTripForm.tsx Outdated Show resolved Hide resolved
frontend/src/hooks/api/useNewTripMutation.ts Show resolved Hide resolved
frontend/src/hooks/common/useCityDateForm.ts Outdated Show resolved Hide resolved
frontend/src/hooks/common/useCityDateForm.ts Outdated Show resolved Hide resolved
frontend/src/hooks/trip/useTripInfoForm.ts Outdated Show resolved Hide resolved
frontend/src/mocks/handlers/trips.ts Outdated Show resolved Hide resolved
dladncks1217
dladncks1217 approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@dladncks1217 dladncks1217 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨습니다 헤다🔥🔥🔥

ashleysyheo
ashleysyheo reviewed Jul 27, 2023
View reviewed changes
Copy link
Collaborator

@ashleysyheo ashleysyheo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고했습니다! 소소하게 스타일 수정 관련해서 밑에 코멘트 남겼습니다. 확인 부탁드려요!!!

Screenshot 2023-07-27 at 10 57 34 AM

너비 맞춰주세요!

Screenshot 2023-07-27 at 10 59 12 AM

그리고 기록들이랑 삭제됩니다 사이 <br /> 삭제해주세요.

Screenshot 2023-07-27 at 11 01 10 AM

검색 결과 없다는 메세지에도 padding-left, right 16px로 맞춰주세요!

Screenshot 2023-07-27 at 11 01 55 AM

textarea resize도 막아주세요!

@Dahyeeee
Copy link
Collaborator Author

디자인 수정했어요!
다만 기록들이 삭제됩니다는
없으면 삭 다음으로 줄바꿈이 되는데 저는 삭제됩니다가 붙어있는게 더 읽기 좋은 것 같아요. 줄바꿈을 하지 말아야할 이유가 있을까요?

@ashleysyheo
Copy link
Collaborator

나중에 모바일에서 화면이 줄어드면 어떻게 될지 모르니까요? 지금 당장은 보기 좋을 수 있어도 모든 상황에서는 대응할 수 없으니까 그냥 <br>을 없애는 것이 더 좋을 것 같아요.

@Dahyeeee
Copy link
Collaborator Author

반응형, 모바일 대응 나중에 진행하기로 한 것 같은데 지금은 일단 이게 보기 좋고 width가 줄어들지 않으니까 그때 같이 수정하도록 하시죠~~

@ashleysyheo
Copy link
Collaborator

Screenshot 2023-07-27 at 2 32 18 PM

그런데 제 컴퓨터에서는 <br>을 없애도 전부 다 들어와요. 이런 비슷한 상황들이 있을 수 있으니까 <br>을 그냥 없애는 것을 제안한거에요! 그리고 지금 width가 448px이어서 반응형 대응을 하면 무조건 화면 너비가 줄어들 것 같아요.

@Dahyeeee
Copy link
Collaborator Author

브라우저마다 좀 다르게 보이나보네요! 알겠습니당

@Dahyeeee Dahyeeee merged commit 6790ad9 into develop Jul 27, 2023
1 check passed
@Dahyeeee Dahyeeee deleted the feature/#69 branch July 27, 2023 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dladncks1217 dladncks1217 dladncks1217 approved these changes

@ashleysyheo ashleysyheo ashleysyheo approved these changes

Assignees

@Dahyeeee Dahyeeee

Labels
FE-Service 행록 서비스 프론트엔드 ✨ Feature
Projects
2023-hang-log
Status: Done
Milestone
3차 스프린트
Development

Successfully merging this pull request may close these issues.

단일 여행 정보 수정 모달 구현
3 participants
@Dahyeeee @ashleysyheo @dladncks1217