도시 검색 기능 특수문자 작성시 버그 수정 + 검색어와 매칭되는 제안도시가 하나일 시 엔터로 적용가능 #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashleysyheo
reviewed
Jul 27, 2023
| @@ -30,7 +30,7 @@ const CitySearchBar = ({ initialCities, updateCityInfo, required = false }: City | |||
| const { cityTags, addCityTag, deleteCityTag } = useCityTags(initialCities ?? []); | |||
| const { isOpen: isSuggestionOpen, open: openSuggestion, close: closeSuggestion } = useOverlay(); | |||
| const inputRef = useRef<HTMLInputElement>(null); | |||
| const debouncedQueryWord = useDebounce(queryWord, 300); | |||
| const debouncedQueryWord = useDebounce(queryWord, 150); | |||
There was a problem hiding this comment.
오 300에서 150으로 바꾼 이유가 있나요??
There was a problem hiding this comment.
쪼금 더 자연스러운 느낌이 들더라구요?! 개인마다 다르겠지만 검색결과 없다는 텍스트도 잘 안보이는 편이라 150~~
|
|
||
| if (e.key === 'Escape') { | ||
| //이거 onClose 프롭스로 받기 싫어서 꼼수로 일단 구현함.... | ||
| onItemSelect(suggestions[-1]); |
There was a problem hiding this comment.
요정도 deps면 그냥 props 받아도 되지 않을까요.....?? props로 넘겨주는게 더 명확할 것 같아요
There was a problem hiding this comment.
ㅋㅋㅋㅋ그럴게요! 뭔가 저 함수 프롭스로 넘겨주는 거 안좋아해여 이유는 없음 ㅋㅋㅋ
dladncks1217
approved these changes
Jul 28, 2023
frontend/src/utils/formatter.ts
Outdated
| @@ -19,3 +19,15 @@ export const dateRangeToString = (dateRange: DateRangeData) => { | |||
|
|
|||
| return `${formatDate(start)} - ${formatDate(end)}`; | |||
| }; | |||
|
|
|||
| export const stringToOnlyLetter = (string: string) => { | |||
| const koreanCharacterRegex = /^[A-Za-z가-힣ㄱ-ㅎ]+$/g; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
특수문자
이거 입력을 아예 못하게 할까 고민했는데 그건 사용자입장에서 좀 아닌 거 같아서
문자만(한글+영어) 정규표현식으로 걸러내게 했어용.
근데 그러면
서+울도서울과 매칭되는 재밌는 결과가 나오는데.. 이에 대해 의견있으시다면 알려주세요!ESC
제안이 뜬 상태에서
esc누르면 제안창이 닫히는 게 좋을 것 같아서 추가했는데 약간 꼼수로직으로 했습니다..헤헤 맘에 안들면 수정가능~~
🙋🏻 More
close #121