TripPage & TripEditPage 모바일 대응 #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
로컬 cypress 테스트가 실패했습니다. 테스트 결과 자세히 보기 |
dladncks1217
approved these changes
Aug 8, 2023
| }, [setIsMobile, setViewportWidth]); | ||
|
|
||
| useEffect(() => { | ||
| const mediaQueryList = window.matchMedia(MOBILE_MEDIA_QUERY_SIZE); |
Dahyeeee
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
🙋🏻 More
일단 모바일에서 지도는 안 보이게 했습니다. 나중에 어느 정도 정리 된 다음에 airbnb 처럼 밑에 버튼을 클릭하면 지도를 볼 수 있게 할 예정입니다. (아마 ? 페이지를 새로 만들고 조건부 렌더링을 해야 해서 일단 보류)
close #360
close #364