Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

토스트 훅으로 분리하고 사용하는 측 코드변경 #423

Merged
merged 85 commits into from
Aug 13, 2023

Conversation

Dahyeeee
Copy link
Collaborator

📄 Summary

image

간단하게 만들어봤습니다.
error가 주로 많아서 default를 error로 하는 건 어떠려나요..?

🙋🏻 More

close #419

Dahyeeee and others added 30 commits August 9, 2023 23:23
Copy link
Member

@dladncks1217 dladncks1217 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥

export const useToast = () => {
const setToastList = useSetRecoilState(toastListState);

const generateToast = (message: string, variant?: ToastType['variant']) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 create가 좋은 것 같습니다!

export const useToast = () => {
const setToastList = useSetRecoilState(toastListState);

const generateToast = (message: string, variant?: ToastType['variant']) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니다👍

@github-actions
Copy link

로컬 cypress 테스트가 실패했습니다. 테스트 결과 자세히 보기

2 similar comments
@github-actions
Copy link

로컬 cypress 테스트가 실패했습니다. 테스트 결과 자세히 보기

@github-actions
Copy link

로컬 cypress 테스트가 실패했습니다. 테스트 결과 자세히 보기

@ashleysyheo ashleysyheo merged commit b3dbd41 into develop Aug 13, 2023
2 checks passed
@ashleysyheo ashleysyheo deleted the feature/#419 branch August 17, 2023 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FE-Service 행록 서비스 프론트엔드 🔨 Refactor
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

toast 생성하는 로직 hook으로 분리
5 participants