Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

인증인가 코드 리팩토링 #436

Merged
merged 8 commits into from
Aug 14, 2023
Merged

인증인가 코드 리팩토링 #436

merged 8 commits into from
Aug 14, 2023

Conversation

ashleysyheo
Copy link
Collaborator

@ashleysyheo ashleysyheo commented Aug 13, 2023

📄 Summary

  • 현재 App에 있는 로그인 로직 컴포넌트로 분리
  • 토큰 에러로 인해 로그아웃 시 쿼리 데이터 지우기

Screenshot 2023-08-13 at 8 02 08 PM
  • 위 문제해결

🙋🏻 More

close #435

@ashleysyheo ashleysyheo added 🔨 Refactor FE-Service 행록 서비스 프론트엔드 labels Aug 13, 2023
@ashleysyheo ashleysyheo added this to the 4차 스프린트 milestone Aug 13, 2023
@ashleysyheo ashleysyheo self-assigned this Aug 13, 2023
@github-actions
Copy link

로컬 cypress 테스트가 실패했습니다. 테스트 결과 자세히 보기

Copy link
Collaborator

@Dahyeeee Dahyeeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와우 버그란 버그는 다 잡는군여 신기신기

@@ -21,7 +21,7 @@ const ImageInput = ({ initialImage, updateCoverImage }: ImageInputProps) => {
uploadedImageUrls: uploadedImageUrl,
handleImageUpload,
handleImageRemoval,
} = useImageUpload({
} = useMultipleImageUpload({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useSingleImageUpload가 있으면 여기도 그거 쓰면 될 듯?! 얘도 하나만 올릴 수 있으니까용~~

@ashleysyheo ashleysyheo merged commit 93113f5 into develop Aug 14, 2023
2 checks passed
@ashleysyheo ashleysyheo deleted the feature/#435 branch August 17, 2023 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug FE-Service 행록 서비스 프론트엔드 🔨 Refactor
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

인증인가 코드 리팩토링
3 participants