Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

모바일 환경에서 StarRatingInput 호버 문제 수정 #550

Merged
merged 2 commits into from
Sep 11, 2023
Merged

모바일 환경에서 StarRatingInput 호버 문제 수정 #550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a8d6d9
refactor: 디자인시스템 1.3.0 버전업
dladncks1217 Sep 7, 2023
13eaee1
refactor: 모바일 환경에서 StarRatingInput 호버 문제 수정
dladncks1217 Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions frontend/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"@tanstack/react-query": "^4.29.19",
"axios": "^1.4.0",
"dotenv": "^16.3.1",
"hang-log-design-system": "^1.3.0",
"hang-log-design-system": "^1.3.1",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-router-dom": "^6.14.1",
Expand Down
4 changes: 3 additions & 1 deletion frontend/src/components/trip/TripItemAddModal/StarRatingInput/StarRatingInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,11 @@ import type { StarRatingData, TripItemFormData } from '@type/tripItem';

interface StarRatingInputProps {
rating: StarRatingData | null;
isMobile: boolean;
updateInputValue: <K extends keyof TripItemFormData>(key: K, value: TripItemFormData[K]) => void;
}

const StarRatingInput = ({ rating, updateInputValue }: StarRatingInputProps) => {
const StarRatingInput = ({ rating, isMobile, updateInputValue }: StarRatingInputProps) => {
const handleRatingChange = (rate: StarRatingData) => {
const newRate = rate || null;
updateInputValue('rating', newRate);
Expand All @@ -22,6 +23,7 @@ const StarRatingInput = ({ rating, updateInputValue }: StarRatingInputProps) =>

return (
<StarRating
isMobile={isMobile}
label="별점"
size={32}
gap={8}
Expand Down
1 change: 1 addition & 0 deletions frontend/src/components/trip/TripItemAddModal/TripItemAddModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ const TripItemAddModal = ({
<StarRatingInput
rating={tripItemInformation.rating}
updateInputValue={updateInputValue}
isMobile={isMobile}
/>
<ExpenseInput
initialExpenseValue={tripItemInformation.expense}
Expand Down
11 changes: 9 additions & 2 deletions frontend/src/stories/trip/StarRatingInput.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,15 @@ const meta = {
component: StarRatingInput,
args: {
rating: 0,
isMobile: false,
},
} satisfies Meta<typeof StarRatingInput>;

export default meta;
type Story = StoryObj<typeof meta>;

export const Default: Story = {
render: () => {
render: ({ ...args }) => {
const [value, setValue] = useState<StarRatingData>(0);

const updateInputValue = <K extends keyof TripItemFormData>(
Expand All @@ -28,6 +29,12 @@ export const Default: Story = {
setValue(value as StarRatingData);
};

return <StarRatingInput rating={value} updateInputValue={updateInputValue} />;
return (
<StarRatingInput
isMobile={args.isMobile}
rating={value}
updateInputValue={updateInputValue}
/>
);
},
};