DB Replication 시 P6spy 로깅으로 인하여 발생하는 문제 해결 #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Nov 3, 2023
waterricecake
approved these changes
Nov 3, 2023
LJW25
approved these changes
Nov 3, 2023
hgo641
approved these changes
Nov 3, 2023
jjongwa
approved these changes
Nov 5, 2023
Comment on lines
38
to
40
| final Class<?> targetClass = targetObject.getClass(); | ||
| return targetClass.getName().contains(HIKARI_CONNECTION_NAME) && | ||
| invocation.getMethod().getName().equals(JDBC_PREPARE_STATEMENT_METHOD_NAME); |
There was a problem hiding this comment.
targetClass로 먼저 받은 이유가 있나용
별 이유 없다면
invocation.getMethod()도 targetMethod로 변수 뺀다음 return값에 넣는게 일관성에 맞을거 같긴 한데
뭐 이런걸 가지고 뭐라 그러냐.. 라는 생각이 들었다면 그냥 무시하고 바로 머지 ㄱㄱ
There was a problem hiding this comment.
📝 Jacoco Test Coverage
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
🙋🏻 More