fix: 세션 조회 로직 변경 (#465)

woowacourse-teams · Oct 19, 2023 · 59ba087 · 59ba087
1 parent 7c3b63d
commit 59ba087
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 9 deletions.
diff --git a/backend/pium/src/main/java/com/official/pium/repository/SessionGroupRepository.java b/backend/pium/src/main/java/com/official/pium/repository/SessionGroupRepository.java
@@ -10,5 +10,5 @@ public interface SessionGroupRepository extends JpaRepository<SessionGroup, Long
 
     void deleteBySessionValue(String sessionValue);
 
-    boolean existsBySessionIdAndSessionKey(String sessionId, String key);
+    boolean existsBySessionIdAndSessionValue(String sessionId, String key);
 }
diff --git a/backend/pium/src/main/java/com/official/pium/service/SessionGroupService.java b/backend/pium/src/main/java/com/official/pium/service/SessionGroupService.java
@@ -45,15 +45,15 @@ private void extendsSession(SessionGroup sessionGroup, LocalDateTime currentTime
 
     @Transactional
     public void add(String sessionId, String key, String value) {
-        if (sessionGroupRepository.existsBySessionIdAndSessionKey(sessionId, key)) {
+        if (sessionGroupRepository.existsBySessionIdAndSessionValue(sessionId, value)) {
             return;
         }
 
         SessionGroup sessionGroup = SessionGroup.builder()
                 .sessionId(sessionId)
                 .sessionKey(key)
                 .sessionValue(value)
-                .expireTime(LocalDateTime.now().plusMinutes(EXTEND_EXPIRED_DAY))
+                .expireTime(LocalDateTime.now().plusDays(EXTEND_EXPIRED_DAY))
                 .build();
         sessionGroupRepository.save(sessionGroup);
     }

diff --git a/backend/pium/src/main/resources/db/migration/V8__session_group_drop_unique.sql b/backend/pium/src/main/resources/db/migration/V8__session_group_drop_unique.sql
@@ -0,0 +1 @@
+ALTER TABLE session_group DROP INDEX uniq_sessions;
diff --git a/backend/pium/src/test/java/com/official/pium/repository/SessionGroupRepositoryTest.java b/backend/pium/src/test/java/com/official/pium/repository/SessionGroupRepositoryTest.java
@@ -88,22 +88,22 @@ class SessionGroupRepositoryTest extends RepositoryTest {
                 .sessionId("UUID.randomUUID().toString()")
                 .sessionKey("KAKAO_ID")
                 .sessionValue("1234546426")
-                .expireTime(LocalDateTime.now().plusMinutes(30))
+                .expireTime(LocalDateTime.now().plusDays(30))
                 .build();
         SessionGroup savedSessionGroup = sessionGroupRepository.save(sessionGroup);
 
-        boolean existsBySessionIdAndSessionKey = sessionGroupRepository.existsBySessionIdAndSessionKey(
+        boolean existsBySessionIdAndSessionValue = sessionGroupRepository.existsBySessionIdAndSessionValue(
                 savedSessionGroup.getSessionId(),
-                savedSessionGroup.getSessionKey()
+                savedSessionGroup.getSessionValue()
         );
 
-        assertThat(existsBySessionIdAndSessionKey).isTrue();
+        assertThat(existsBySessionIdAndSessionValue).isTrue();
     }
 
     @Test
     void 기존_세션이_존재하지않으면_False() {
-        boolean existsBySessionIdAndSessionKey = sessionGroupRepository.existsBySessionIdAndSessionKey(
-                "id", "sessionKey"
+        boolean existsBySessionIdAndSessionKey = sessionGroupRepository.existsBySessionIdAndSessionValue(
+                "id", "sessionValue"
         );
 
         assertThat(existsBySessionIdAndSessionKey).isFalse();