Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 이미지 로컬로 저장하도록 수정 #479

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

Choi-JJunho
Copy link
Collaborator

🔥 연관 이슈

🚀 작업 내용

  • 이미지를 로컬에 저장하도록 수정했습니다.
  • 조이, 하마드, 그레이와 몹프로그래밍을 했습니다 :)

💬 리뷰 중점사항

잘부탁드립니다

@Choi-JJunho Choi-JJunho added 🛠️ 리팩터링 리팩터링을 위한 이슈입니다 🍉 백엔드 백엔드 관련 이슈입니다 labels Nov 22, 2023
@Choi-JJunho Choi-JJunho self-assigned this Nov 22, 2023
Copy link

github-actions bot commented Nov 22, 2023

Unit Test Results

  87 files  ±0    87 suites  ±0   16s ⏱️ -9s
364 tests ±0  364 ✔️ ±0  0 💤 ±0  0 ±0 
370 runs  ±0  370 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 42e18e2. ± Comparison against base commit 7dac0bb.

♻️ This comment has been updated with latest results.


private String getFileLocalPath(String fullPath) {
int urlIndex = fullPath.lastIndexOf(webPath);
if (urlIndex == -1) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C

매직넘버로 빼봅시다 ㅎㅎ

Copy link
Member

@yeonkkk yeonkkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 ~~

Copy link
Collaborator

@Kim0914 Kim0914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

함께해서 즐거운 피움 ㅎㅎ
고생많았습니다 ~

@Kim0914 Kim0914 merged commit ffbb49d into develop Nov 22, 2023
4 checks passed
@Kim0914 Kim0914 deleted the refactor/477-image_local_save branch November 22, 2023 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍉 백엔드 백엔드 관련 이슈입니다 🛠️ 리팩터링 리팩터링을 위한 이슈입니다
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

서버 이관으로 인한 이미지 저장 로직 수정
3 participants