refactor: 알림 기능 로직 개선 및 알림 테스트 추가 #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kim0914
changed the title
This comment has been minimized.
This comment has been minimized.
Choi-JJunho
approved these changes
Jan 22, 2024
|
|
||
| @Configuration | ||
| @EnableAsync | ||
| public class AsyncConfig implements AsyncConfigurer { |
There was a problem hiding this comment.
A
오 비동기 설정을 별도로 분리했군요! 👍
| public Executor getAsyncExecutor() { | ||
| ThreadPoolTaskExecutor executor = new ThreadPoolTaskExecutor(); | ||
| executor.setCorePoolSize(40); | ||
| executor.setThreadNamePrefix("2024-Pium-Thread: "); |
Comment on lines
27
to
29
| @Async | ||
| public void handleNotificationEvents(NotificationEvents notificationEvents) { | ||
| log.info("동기 알림 START, Thread: " + Thread.currentThread().getId() + " " + Thread.currentThread().getName()); |
There was a problem hiding this comment.
A
잘 몰라서 여쭤봅니다~
@Async 가 붙어있는데도 동기적으로 동작하는건가요?
There was a problem hiding this comment.
지워야 하는 메소드인데 그대로 두고 있었군요...!
지금은 @EnableAsync 설정 때문에 본 메소드도 비동기적으로 동작하게 됩니다.
그러나 결국 이벤트 내부에서는 단일 스레드가 모든 notificationEvents를 처리하고 있어 여러개의 알림을 병렬적으로 처리할 수가 없는 상황인데 위 메소드의 단점이었어요ㅠㅠ
위 메소드는 지우도록 하겠습니다!
|
|
||
| @DisplayNameGeneration(DisplayNameGenerator.ReplaceUnderscores.class) | ||
| @SuppressWarnings("NonAsciiCharacters") | ||
| @ExtendWith(DatabaseClearExtension.class) | ||
| @RecordApplicationEvents |
There was a problem hiding this comment.
A
Test환경에서 이벤트를 기록하고 확인할 수도 있군요!
지식이 늘었네요 👍
| @@ -42,6 +46,9 @@ class MemberServiceTest { | |||
| @Autowired | |||
| private PetPlantRepository petPlantRepository; | |||
|
|
|||
| @Autowired | |||
| private ApplicationEvents applicationEvents; | |||
There was a problem hiding this comment.
A
이 친구가 이벤트 호출 횟수를 기록해주는군요! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
※ 해당 PR 및 커밋은 이건회(@rawfishthelgh )와 함께 몹 프로그래밍으로 작성했습니다
🔥 연관 이슈
🚀 작업 내용
AsyncConfig클래스 내부에서 비동기를 위한 스레드 풀을 재정의 했습니다.40으로 설정했습니다.AsyncConfig내에서 스레드 풀 설정 시queueCapacity,maxPoolSize는 기본 설정으로 유지했습니다.TestController는 테스트를 위해 주석처리하고 남겨두었습니다 !💬 리뷰 중점사항
큰 변경사항은 없고 성능 테스트와 트러블 슈팅 때문에 시간이 조금 소요되었습니다 😃