Skip to content

Refactor/#551 SongDetailListPage의 스와이프 추가 fetch 옵져버 로직에 callbackRef를 적용하여 로직 흐름을 개선한다. #545

Refactor/#551 SongDetailListPage의 스와이프 추가 fetch 옵져버 로직에 callbackRef를 적용하여 로직 흐름을 개선한다.

Refactor/#551 SongDetailListPage의 스와이프 추가 fetch 옵져버 로직에 callbackRef를 적용하여 로직 흐름을 개선한다. #545

Triggered via pull request November 6, 2023 10:29
Status Success
Total duration 1m 17s
Artifacts

frontend-ci.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
test: frontend/src/features/comments/components/CommentList.tsx#L33
React Hook useEffect has a missing dependency: 'getComment'. Either include it or remove the dependency array
test: frontend/src/features/songs/components/CollectingPartProvider.tsx#L102
React Hook useEffect has a missing dependency: 'seekTo'. Either include it or remove the dependency array
test: frontend/src/features/songs/components/CollectingPartProvider.tsx#L106
React Hook useEffect has a missing dependency: 'forceScrollWave'. Either include it or remove the dependency array
test: frontend/src/features/songs/components/SongDetailItem.tsx#L41
React Hook useCallback has missing dependencies: 'genre', 'id', and 'navigate'. Either include them or remove the dependency array
test: frontend/src/features/songs/hooks/useExtraSongDetail.ts#L35
React Hook useCallback has missing dependencies: 'fetchExtraPrevSongDetails' and 'genreParams'. Either include them or remove the dependency array
test: frontend/src/features/songs/hooks/useExtraSongDetail.ts#L48
React Hook useCallback has missing dependencies: 'fetchExtraNextSongDetails' and 'genreParams'. Either include them or remove the dependency array
test: frontend/src/features/youtube/components/Youtube.tsx#L49
React Hook useCallback has missing dependencies: 'bindUpdatePlayerStateEvent', 'controls', 'initPlayer', 'start', and 'videoId'. Either include them or remove the dependency array
test: frontend/src/pages/AuthPage.tsx#L43
React Hook useEffect has a missing dependency: 'getAccessToken'. Either include it or remove the dependency array
test: frontend/src/pages/SearchResultPage.tsx#L23
React Hook useEffect has a missing dependency: 'refetchSingerSearch'. Either include it or remove the dependency array
test: frontend/src/pages/SingerDetailPage.tsx#L20
React Hook useEffect has a missing dependency: 'refetchSingerDetail'. Either include it or remove the dependency array