Refactor/#555 프로젝트 동의를 구하는 모달을 confirmModal로 리팩터링 #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 짧은 문장도 잘 담지 못해서 줄바꿈이 일어남. 그래서 너비를 늘림
ukkodeveloper
added
[ 🌞 FE ]
ukkodeveloper
requested review from
Creative-Lee and
cruelladevil
as code owners
Creative-Lee
approved these changes
Dec 22, 2023
|
|
||
| await deleteMemberPart(); | ||
| if (isConfirmed) { | ||
| if (!hideMyPart) return; |
There was a problem hiding this comment.
마이파트 관련 긴급 수정 하면서 추가된 함수 props 이네용
💬 요거 if문 한 줄로 줄여지지 않나용?
There was a problem hiding this comment.
- isConfirmed : 유저 인터렉션을 통한 조건
- hideMyPart: optional 데이터 타입가드
이렇게 조건문의 맥락이 다르기 때문에 나눴어요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝작업 내용
프로젝트 동의를 구하는 모달을 confirmModal로 리팩터링했습니다.
💬리뷰 참고사항
#️⃣연관된 이슈
close #555