Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] common-global package 분배, 일부 양방향 의존 해결 #961

Merged
merged 3 commits into from
Mar 27, 2024
Merged

[BE] common-global package 분배, 일부 양방향 의존 해결 #961

merged 3 commits into from
Mar 27, 2024

Conversation

pilyang
Copy link
Collaborator

@pilyang pilyang commented Mar 27, 2024

PR 내용

  • global -> domain pacakges -> common 방향으로 의존성 흐름 정리
  • filesystem package에서 feed패키지에 의존하는 문제 해결

추후 참고사항

  • Member 관련 패키지 추가 작업필요
    • 인증관련해서 변화가 복잡할것으로 판단되어 PR분리
    • 마찬가지로 member - memberTeamPlace - teamPlace 사이 관계도 분리

@pilyang
refactor: move baseentity to common
5a2a303
@pilyang
refactor: FileControlException에 확장자 예외 추가
11085b8 
- feed -> filesystem 의존성 방향으로 수정
- feed, notice service에서 해당 exception을 각각의 도메인 예외로 변환
@pilyang
refactor: move Response dto to application dto package
eecf6d2
@pilyang pilyang self-assigned this Mar 27, 2024
@github-actions GitHub Actions
Copy link

Test Results

153 files  153 suites   21s ⏱️
500 tests 500 ✅ 0 💤 0 ❌
504 runs  504 ✅ 0 💤 0 ❌

Results for commit eecf6d2.

@pilyang pilyang merged commit cddc2eb into develop Mar 27, 2024
3 checks passed
@pilyang pilyang deleted the refactor/be/common-global branch March 27, 2024 15:04
@pilyang pilyang mentioned this pull request Apr 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pilyang pilyang

Labels
중요도-중 🍃 백엔드 🔨 리팩터링
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pilyang