Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

템플릿 CRUD API의 실패 응답 문서화 #109

Merged
merged 11 commits into from
Jul 24, 2024
Merged

템플릿 CRUD API의 실패 응답 문서화 #109

merged 11 commits into from
Jul 24, 2024

Conversation

jminkkk
Copy link
Contributor

@jminkkk jminkkk commented Jul 23, 2024 •
edited
Loading

⚡️ 관련 이슈

close #108, #111

📍주요 변경 사항

  1. 템플릿 생성, 목록 및 단건 조회 API의 실패 응답 문서화하였습니다.
  2. 응답 및 요청 객체에 필드 설명 추가하였습니다.
  3. 템플릿 수정, 삭제 API의 문서를 작성했습니다.

🎸기타

  1. 수정, 삭제 dto를 생성하였으나 문서화에 대한 내용만 추가하였습니다.
  1. 실패 케이스에 대한 예외 응답을 정하지 않아 문서화되어 있지 않습니다.
  • API 구현 후 예외 응답에 대한 문서화를 추가해주세요~! @HoeSeong123 @zangsu

@jminkkk jminkkk added documentation 문서 작업 BE 백엔드 labels Jul 23, 2024
@jminkkk jminkkk added this to the 2차 스프린트 🐣 milestone Jul 23, 2024
@jminkkk jminkkk changed the title 템플릿 생성, 목록 및 단건 조회 API의 실패 응답 문서화 템플릿 CRUD API의 실패 응답 문서화 Jul 24, 2024
HoeSeong123
HoeSeong123 previously approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@HoeSeong123 HoeSeong123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

깔끔하고 보기 좋네요.
고생하셨습니다~

zeus6768
zeus6768 previously approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@zeus6768 zeus6768 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

몰리 켬미 고생많았어요!

@jminkkk jminkkk dismissed stale reviews from zeus6768 and HoeSeong123 via d76ce5f July 24, 2024 04:08
kyum-q
kyum-q previously approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@kyum-q kyum-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

최고에요 몰리 켬미 짱 ~!

HoeSeong123
HoeSeong123 previously approved these changes Jul 24, 2024
View reviewed changes
zangsu
zangsu previously approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@zangsu zangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

하나 둘 셋 하면 코드잽 파이팅 하겠습니다.
하나 둘 셋
코드잽 파이팅!!!!
수고하셨습니다!

@jminkkk @kyum-q
docs: 오타 수정
725ea1e 
Co-authored-by: kyum-q <[email protected]>
@jminkkk jminkkk dismissed stale reviews from zangsu and HoeSeong123 via 725ea1e July 24, 2024 04:17
zangsu
zangsu approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@zangsu zangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

하나 둘 셋 하면 코드잽 파이팅 하겠습니다.
하나 둘 셋

코드잽 파이팅!!!!

수고하셨습니다!

@zeus6768 zeus6768 merged commit 0b7d0dc into woowacourse-teams:dev/be Jul 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zangsu zangsu zangsu approved these changes

@zeus6768 zeus6768 zeus6768 approved these changes

@kyum-q kyum-q kyum-q approved these changes

@HoeSeong123 HoeSeong123 HoeSeong123 approved these changes

Assignees

@jminkkk jminkkk

@kyum-q kyum-q

Labels
BE 백엔드 documentation 문서 작업
Projects
2024-code-zap
Status: Weekend Done
Milestone
2차 스프린트 🐣
Development

Successfully merging this pull request may close these issues.
5 participants
@jminkkk @zangsu @zeus6768 @kyum-q @HoeSeong123