템플릿 목록 조회, 상세 조회, 생성 요청 로직 리펙토링 #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
api 요구사항에 맞게 응답 json 객체 키 카멜케이스로 변경
vi-wolhwa
previously approved these changes
Jul 24, 2024
…de-zap into refactor/templates_api
Jaymyong66
reviewed
Jul 24, 2024
| @@ -0,0 +1,4 @@ | |||
| export const QUERY_KEY = { | |||
There was a problem hiding this comment.
키를 쓸 때 Symbol 데이터 타입을 고려해봐도 좋겠네요!
frontend/src/api/config.ts
Outdated
Comment on lines
3
to
5
| export const END_POINT = { | ||
| TEMPLATES: '/templates', | ||
| }; |
There was a problem hiding this comment.
당장은 이렇게 파일을 분리하지 않고, templates.ts 파일을 분리한다면 관련 엔드포인트도 해당 파일에 모아두는 것도 방법일 것 같아요~!
Comment on lines
+28
to
+31
| await waitFor(() => { | ||
| expect(result.current.isSuccess).toBe(true); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
추후에 isSuccess가 true인지 확인 + 실제 데이터가 들어갔는지 확인해도 좋을 것 같아요.
vi-wolhwa
approved these changes
Jul 24, 2024
Jaymyong66
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚡️ 관련 이슈
close #103
📍주요 변경 사항
1. dotenv 설치 및 webpack 설정 추가
2. endPoint 상수화 및 api 요청 함수 별도로 분리(
api/templates) 및 테스트 작성3. UploadsTemplate => TemplateUpload 로 변경
4. 응답 json 객체 키 카멜케이스로 변경
5. msw browser 설정
🎸기타