Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI에서는 h2 사용으로 변경 #244

Closed
wants to merge 153 commits into from

Conversation

kyum-q
Copy link
Contributor

@kyum-q kyum-q commented Aug 2, 2024

⚡️ 관련 이슈

close #246

📍주요 변경 사항

CI에서 MySQL 사용을 h2 사용하도록 변경

AS-IS

MySQL 사용

TO-BE

h2 사용으로 변경

🤔 기한

2024-08-02 오후 11:59

🎸기타

이슈에 왜 h2로 변경하는지 간략하게 적어놨습니다.
궁금하시다면 이슈를 확인해주세요.

Hain-tain and others added 30 commits July 18, 2024 17:53
* chore: eslint 설정 추가

Co-Authored-By: MYONG JAEWI <[email protected]>
Co-Authored-By: 월하 <[email protected]>

* style(src): eslint 적용

Co-Authored-By: MYONG JAEWI <[email protected]>
Co-Authored-By: 월하 <[email protected]>

* chore: stylelint 설정 추가

Co-Authored-By: MYONG JAEWI <[email protected]>
Co-Authored-By: 월하 <[email protected]>

* style(components): stylelint 적용

Co-Authored-By: MYONG JAEWI <[email protected]>
Co-Authored-By: 월하 <[email protected]>

* chore: stylelint 라이브러리, config 파일 수정

* style(components): stylelint 재적용

Co-Authored-By: MYONG JAEWI <[email protected]>
Co-Authored-By: 월하 <[email protected]>

---------

Co-authored-by: MYONG JAEWI <[email protected]>
Co-authored-by: 월하 <[email protected]>
Co-authored-by: jayming66 <[email protected]>
stylelint extension 사용으로 저장시 자동 Fix 기능을 이용하기 위함.
제거한 패키지로 인해 다른 eslint와 충돌, Fix 되지 않았음.
Webpack과 MSW v2 이슈로 jest.polyfills.js를 구성해줬어야함.
@kyum-q kyum-q requested review from Jaymyong66, zeus6768, jminkkk and HoeSeong123 and removed request for Jaymyong66 August 2, 2024 07:51
@kyum-q kyum-q self-assigned this Aug 2, 2024
@kyum-q kyum-q added refactor 요구사항이 바뀌지 않은 변경사항 BE 백엔드 labels Aug 2, 2024
@kyum-q kyum-q added this to the 3차 스프린트 🐤 milestone Aug 2, 2024
@kyum-q kyum-q added the zap 리뷰 우선순위가 높은 사항 label Aug 2, 2024
@kyum-q kyum-q changed the title [REFACTOR] CI에서는 h2 사용으로 변경 CI에서는 h2 사용으로 변경 Aug 2, 2024
@kyum-q kyum-q closed this Aug 2, 2024
@kyum-q kyum-q reopened this Aug 2, 2024
jminkkk
jminkkk previously approved these changes Aug 2, 2024
Copy link
Contributor

@jminkkk jminkkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와우~ 켬미 짱

HoeSeong123
HoeSeong123 previously approved these changes Aug 2, 2024
Copy link
Contributor

@HoeSeong123 HoeSeong123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~

Copy link
Contributor

@zeus6768 zeus6768 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

켬미 최고에요 👍👍👍

zeus6768
zeus6768 previously approved these changes Aug 2, 2024
@kyum-q kyum-q dismissed stale reviews from zeus6768, HoeSeong123, and jminkkk via 2bdaef7 August 2, 2024 09:26
@kyum-q
Copy link
Contributor Author

kyum-q commented Aug 3, 2024

브랜치에 다른 커밋들이 추가되서 해당 이슈는 닫고 다시 리뷰 요청 드리겠습니다

@kyum-q kyum-q closed this Aug 3, 2024
@kyum-q kyum-q reopened this Aug 3, 2024
@kyum-q kyum-q closed this Aug 3, 2024
@kyum-q kyum-q deleted the refactor/ci-h2 branch August 5, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BE 백엔드 refactor 요구사항이 바뀌지 않은 변경사항 zap 리뷰 우선순위가 높은 사항
Projects
Status: Weekend Done
Development

Successfully merging this pull request may close these issues.

7 participants