스프링단 로그 추가 #245
Merged
스프링단 로그 추가 #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zangsu
reviewed
Aug 3, 2024
| @RestControllerAdvice | ||
| public class GlobalExceptionHandler { | ||
|
|
||
| @ExceptionHandler | ||
| public ResponseEntity<ProblemDetail> handleCodeZapException(CodeZapException codeZapException) { | ||
| log.info("[CodeZapException] {}가 발생했습니다.", codeZapException.getClass().getName(), codeZapException); |
There was a problem hiding this comment.
우리가 충분히 예상하고, 예외 처리를 해 준 상황이 INFO 레벨의 로그에 기록되는 것이 조금은 어색하게 느껴져요.
혹시 아직 로그 레벨에 대한 논의가 진행되지 않았다면, 같이 이야기를 해 보아도 좋을 것 같아요!
꼭 수정해야 하는 것은 아니기에 우선 comment 만 남겨두고 Approve 할게요
There was a problem hiding this comment.
예상했기 때문에 ERROR나 WARN가 아닌 INFO로 설정해두긴 했었어요...!
크리티컬하지는 않지만 사용자에게 400대 응답이 간 것이기 때문에 정보로 남길 필요가 있다고 생각했기 때문에요~
혹시 짱수는 400대 에러에는 어느 레벨이 적절한지 생각하는지 궁금해요!
+) 디스커션으로 얘기 해보면 좋을 것 같아요!
zangsu
approved these changes
Aug 3, 2024
HoeSeong123
approved these changes
Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚡️ 관련 이슈
close #207
📍주요 변경 사항